-
-
Notifications
You must be signed in to change notification settings - Fork 137
feat: IPC Server, Controller For Swarm Control [WIP] #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Egezenn
wants to merge
9
commits into
SDClowen:master
Choose a base branch
from
Egezenn:feat/ipc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,272
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several new functionalities and improvements to the Inter-Process Communication (IPC) system: - **Client Management Commands:** - Implemented `LaunchClient` command: Allows launching a game client instance remotely via IPC. - Implemented `KillClient` command: Enables terminating a running game client instance remotely via IPC. - Implemented `SetClientVisibility` command: Provides the ability to show or hide the game client window remotely via IPC. - **Batch Command Operations:** - Added `--all` option to `RSBot.Controller`: Users can now send a single command to all connected bot instances listening on a specific IPC server. - Enhanced `RSBot.Server` routing: The server now correctly broadcasts commands to all bot clients when the `TargetAllProfiles` flag is set in an `IpcCommand`. - Improved `RSBot.Controller` response handling: The controller now collects and displays all responses from multiple bot instances when a batch command is executed, rather than just the first response. - **IPC Structure Updates:** - Added `TargetAllProfiles` boolean property to `IpcCommand` to facilitate batch command routing. These changes significantly enhance the control and flexibility of managing multiple RSBot instances via the command-line interface.
fix a build error on server
Owner
|
Geliştirmeye devam ediyor musun? |
Contributor
Author
|
Şu an Silkroad oynamıyorum o sebeple üstüne gitmedim bu hali dışında. Bıraktığımda diyagramdaki tikli şeylerin hepsi çalışıyodu, sadece autologin oluşturmada bi sıkıntı vardı. Argümanların aliasları da düzeltilirse daha iyi bi manager için kullanılabilir durumda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effort to better expose bots' functionality for headless & programmatic control.
User is able to create named pipes with the name they specify and the bot can listen to that pipe. Allowing seperation for multiple swarms. Features are to be tested. Need better aliases for the options (gave a random one for each, to be made semantic™️)
All communication is made via JSON.
Example command line interface functionality exposed via this PR:
RSBot
IPC Server to Listen to
RSBotIPCpipe is default in Server and Controller, however the user explicitly needs to specify the server to be listened.RSBot.exe -p profile -l RSBotIPCAutologin
Creating a New Autologin
RSBot.exe -p profile -e(--create-autologin) --username username --password passwordRSBot.exe -p profile -e --username username --password password --secondary-password --provider-name JCPlanet --server XianSelecting an Autologin
RSBot.exe -p profile -a(--select-autologin) usernameRSBot.Server
A background process for bots to connect to and for the controller to relay messages to. Everything is logged onto
User/Logs/Environment/Server.exe.RSBot.Server -x(--pipename) RSBotIPCRSBot.Controller
Command line interface to control the bot without any GUI.
RSBot.Controller.exe -x RSBotIPC -p(--profile) profile -c(--command) command -d(--data) dataRSBot.Controller.exe -x RSBotIPC -a(--all) -c command -d dataCommands are:
Roughly Desired Architecture
Multiple ipc servers can coexist, they should be named differently.
Diagram of Operations
sequenceDiagram participant CLI as RSBot.Controller.exe participant Server as RSBot.Server.exe participant Bot as RSBot.exe Server->>Server: Start and create Named Pipe Bot->>Server: Connect to Named Pipe Server-->>Bot: Connection established Bot->>Server: Send RegisterBot command Server->>Server: Register Bot instance with profile CLI->>Server: Connect to Named Pipe Server-->>CLI: Connection established CLI->>Server: Send GetInfo command Server->>Bot: Route GetInfo command Bot->>Bot: Process GetInfo command (gather info) Bot->>Server: Send IpcResponse with info Server->>CLI: Route IpcResponse CLI->>CLI: Display response CLI->>Server: Disconnect Server-->>CLI: Acknowledge disconnect