Skip to content

Conversation

@perryr16
Copy link
Contributor

@perryr16 perryr16 commented Jul 2, 2025

Contents

Fixes navigation bug

  • Inventory list shortcut icons (info, notes, meters...) were using the property_id not the property_view_id for navigation.
  • Analyses pages were using property field for navigation (which is property_id), now using the original_view (which is property_view_id)

Fixes org change on inventory list

  • many of the inventory list service calls would compound if you left the list and returned (inv list > detail > inv list). For example if you watched the number of /filter calls in the network tab, they would increase on each time you returned to the inventory list.
  • moving the unsubscribe command to last in the chain prevented these duplicate service calls

Testing

  • upload some properties
  • delete those properties
  • upload the same properties (now the Property ID and Property View ID are different)
  • use the inventory list shortcut buttons to navigate to the inventory detail
  • use the analyses pages to navigate to property detail

@perryr16 perryr16 requested a review from kflemin July 2, 2025 19:18
@kflemin kflemin merged commit e874eaa into main Jul 2, 2025
2 checks passed
@kflemin kflemin deleted the bug/view-id-param branch July 2, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants