Fix package name and URLs in pyproject.toml#3
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 21 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughUpdated the package's declared distribution name from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 3 3
Lines 551 551
Branches 110 110
=======================================
Hits 513 513
Misses 19 19
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pyproject.toml (1)
73-87:⚠️ Potential issue | 🔴 CriticalUpdate distribution name references in
[project.optional-dependencies].devfrom old name to new name.Lines 75 and 86 still reference the old distribution name
psfmodel. After the rename torms-psfmodel, these self-references will fail to resolve correctly. When installingpip install rms-psfmodel[dev], pip will attempt to fetch a separatepsfmodelpackage from PyPI, and thepsfmodel[docs]extras pattern will not pull this project's docs dependencies.🔧 Proposed fix
dev = [ - "psfmodel", + "rms-psfmodel", "coverage>=7.0", "mypy>=1.0", "pymarkdownlnt>=0.9.35", "pytest>=7.0", "pytest-cov>=4.0", "pytest-xdist>=3.8.0", "ruff>=0.8", "bandit[toml]>=1.8", "pyroma>=4.2", "vulture>=2.14", - "psfmodel[docs]", + "rms-psfmodel[docs]", ]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` around lines 73 - 87, Update the package self-references in the [project.optional-dependencies].dev list: replace the old distribution name "psfmodel" and the extras form "psfmodel[docs]" with the new distribution name "rms-psfmodel" and "rms-psfmodel[docs]" respectively so the dev extras point to this package itself (check the entries in pyproject.toml under the dev array).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@pyproject.toml`:
- Around line 73-87: Update the package self-references in the
[project.optional-dependencies].dev list: replace the old distribution name
"psfmodel" and the extras form "psfmodel[docs]" with the new distribution name
"rms-psfmodel" and "rms-psfmodel[docs]" respectively so the dev extras point to
this package itself (check the entries in pyproject.toml under the dev array).
1 participant
Purpose
The package name and project URLs in
pyproject.tomlstill referenced the old repository name (psfmodel) rather than the current one (rms-psfmodel). This caused the published PyPI package name and all documentation/source links to point to the wrong location.Closes #
Changes/Implementation Details
[project] namefrompsfmodeltorms-psfmodelto match the repository name and PyPI package name convention used across the SETIrms-*package family.[project.urls]entries (Homepage,Documentation,Repository,Source,Issues) fromgithub.com/SETI/psfmodel/psfmodel.readthedocs.ioto theirrms-psfmodelequivalents.Type of Change
Testing
Verified that
pyproject.tomlparses correctly and the corrected URLs resolve to the right locations.Potential Impacts
Anyone who installed the package as
pip install psfmodelwill need to switch topip install rms-psfmodel. No Python source code or public API was changed.Checklist
ruff check,ruff format)mypypassesNotes
This is a metadata-only fix; no logic was changed. The previous name
psfmodelwas almost certainly a leftover from before the repository was renamed torms-psfmodel.Made with Cursor
Summary by CodeRabbit
rms-psfmodel