Added in a read_multi() function for Rails 3 users#4
Open
dazoakley wants to merge 6 commits intoSFEley:masterfrom
dazoakley:master
Open
Added in a read_multi() function for Rails 3 users#4dazoakley wants to merge 6 commits intoSFEley:masterfrom dazoakley:master
dazoakley wants to merge 6 commits intoSFEley:masterfrom
dazoakley:master
Conversation
added 6 commits
March 17, 2011 13:45
…db rather than lots of small ones.
…ive bunch of keys to retrieve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using your gem (which is great - thanks for putting it together) for a little while and added in this slight optimisation for the read_multi function.
By default ActiveSupport::Cache::Store will just call read_entry() multiple times - thus making many requests to the database, this new function wraps it all up into a single request so will reduce load on the database and should also make requests for multiple objects from the cache faster.
Hope you like the addition, let me know if there are any problems or you can suggest any improvements/changes.
Thanks,
Daz