Revert "Update Numeric Types: Add int64 and string support for AttributeTypeInt64"#97
Conversation
…uteTypeI…" This reverts commit 30a11c0.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes that added int64 and string parsing support for AttributeTypeInt64 and AttributeTypeDouble. The revert is being done to investigate potential impacts on customers before implementing the enhanced numeric type handling.
Key changes reverted:
- Removed enhanced string parsing for int64 and double attribute types
- Removed precision safety checks for int64 conversions from float64
- Removed comprehensive test coverage for the enhanced numeric type support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/json_value.go | Reverted int64 and double attribute parsing logic to original simple float64 casting |
| web/json_value_test.go | Removed test cases for string parsing of int64 and double types |
| web/json_object_test.go | Removed comprehensive test suite for enhanced numeric type handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 50.18% 48.70% -1.49%
==========================================
Files 24 24
Lines 2676 2655 -21
==========================================
- Hits 1343 1293 -50
- Misses 1287 1306 +19
- Partials 46 56 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #93
The reason to revert this change is as it implies changes to be done is adapter and there needs a deep investigation on how it will affect the customers. After this investigation is completed we can merge this change again.