Skip to content

Revert "Update Numeric Types: Add int64 and string support for AttributeTypeInt64"#97

Merged
Saurabhdarekar merged 1 commit intomainfrom
revert-93-Update-Numeric-Types
Sep 17, 2025
Merged

Revert "Update Numeric Types: Add int64 and string support for AttributeTypeInt64"#97
Saurabhdarekar merged 1 commit intomainfrom
revert-93-Update-Numeric-Types

Conversation

@Saurabhdarekar
Copy link
Copy Markdown
Contributor

Reverts #93

The reason to revert this change is as it implies changes to be done is adapter and there needs a deep investigation on how it will affect the customers. After this investigation is completed we can merge this change again.

@Saurabhdarekar Saurabhdarekar requested a review from a team as a code owner September 17, 2025 17:58
Copilot AI review requested due to automatic review settings September 17, 2025 17:58
@Saurabhdarekar Saurabhdarekar self-assigned this Sep 17, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes that added int64 and string parsing support for AttributeTypeInt64 and AttributeTypeDouble. The revert is being done to investigate potential impacts on customers before implementing the enhanced numeric type handling.

Key changes reverted:

  • Removed enhanced string parsing for int64 and double attribute types
  • Removed precision safety checks for int64 conversions from float64
  • Removed comprehensive test coverage for the enhanced numeric type support

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
web/json_value.go Reverted int64 and double attribute parsing logic to original simple float64 casting
web/json_value_test.go Removed test cases for string parsing of int64 and double types
web/json_object_test.go Removed comprehensive test suite for enhanced numeric type handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread web/json_value.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.70%. Comparing base (8183adf) to head (6815f1b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
web/json_value.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   50.18%   48.70%   -1.49%     
==========================================
  Files          24       24              
  Lines        2676     2655      -21     
==========================================
- Hits         1343     1293      -50     
- Misses       1287     1306      +19     
- Partials       46       56      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Saurabhdarekar Saurabhdarekar merged commit bda5618 into main Sep 17, 2025
6 of 7 checks passed
@Saurabhdarekar Saurabhdarekar deleted the revert-93-Update-Numeric-Types branch September 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants