Skip to content

[sc-58699] Fix JQL array attributes and supporting child entities#153

Merged
aj-chandel merged 7 commits intomainfrom
jira_array_fields
Sep 17, 2025
Merged

[sc-58699] Fix JQL array attributes and supporting child entities#153
aj-chandel merged 7 commits intomainfrom
jira_array_fields

Conversation

@aj-chandel
Copy link
Copy Markdown
Collaborator

Description of changes

  • Strip array indices and square brackets from field names in JQL queries for issues
  • Include additional field names from child entities in JQL queries

API References

Pull request intention

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code improvement (improve test coverage or code readability)

Pull request checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated documentation (if applicable)
  • I have registered the new adapter (if applicable)
  • I have added a smoke test for the new adapter (if applicable)
  • Any secrets are redacted from smoke test fixtures and no PII is present (if applicable)

@aj-chandel aj-chandel requested a review from a team as a code owner September 16, 2025 16:45
Copilot AI review requested due to automatic review settings September 16, 2025 16:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes handling of array attributes and child entities in JQL (Jira Query Language) field parameter construction. The main purpose is to properly strip array indices from field names and include child entity attributes when building JQL queries.

  • Strip array indices and square brackets from field names (e.g., customfield_10209[0]customfield_10209)
  • Include field names from child entities in JQL field parameter construction
  • Refactor field parameter building to support entity configurations with nested child entities

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/jira-datacenter/datasource.go Core logic changes: added array index removal and child entity field extraction
pkg/jira-datacenter/client.go Added Entity field to Request struct to support entity configuration
pkg/jira-datacenter/adapter.go Updated to pass entity configuration to datasource requests
pkg/jira-datacenter/datasource_test.go Comprehensive test coverage for new functionality including array handling and child entities
pkg/jira-datacenter/adapter_test.go Integration tests for adapter with child entity scenarios
pkg/jira-datacenter/config.go Minor optimization moving group map initialization outside loop

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pkg/jira-datacenter/datasource.go Outdated
Comment thread pkg/jira-datacenter/datasource.go
@aj-chandel aj-chandel changed the title Fix JQL array attributes and supporting child entities [sc-58699] Fix JQL array attributes and supporting child entities Sep 16, 2025
Copy link
Copy Markdown
Contributor

@dhanya-sgnl dhanya-sgnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall but I had one request and one nit.

Comment thread pkg/jira-datacenter/datasource.go
Comment thread pkg/jira-datacenter/datasource_test.go
@aj-chandel
Copy link
Copy Markdown
Collaborator Author

FYI..PR #140, needs to be merged to fix some of the int64/float changes in the framework. Some of the tests are failing as result of that.

dhanya-sgnl
dhanya-sgnl previously approved these changes Sep 17, 2025
@aj-chandel aj-chandel merged commit a1e2215 into main Sep 17, 2025
9 checks passed
@aj-chandel aj-chandel deleted the jira_array_fields branch September 17, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants