[sc-58699] Fix JQL array attributes and supporting child entities#153
Merged
aj-chandel merged 7 commits intomainfrom Sep 17, 2025
Merged
[sc-58699] Fix JQL array attributes and supporting child entities#153aj-chandel merged 7 commits intomainfrom
aj-chandel merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes handling of array attributes and child entities in JQL (Jira Query Language) field parameter construction. The main purpose is to properly strip array indices from field names and include child entity attributes when building JQL queries.
- Strip array indices and square brackets from field names (e.g.,
customfield_10209[0]→customfield_10209) - Include field names from child entities in JQL field parameter construction
- Refactor field parameter building to support entity configurations with nested child entities
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/jira-datacenter/datasource.go | Core logic changes: added array index removal and child entity field extraction |
| pkg/jira-datacenter/client.go | Added Entity field to Request struct to support entity configuration |
| pkg/jira-datacenter/adapter.go | Updated to pass entity configuration to datasource requests |
| pkg/jira-datacenter/datasource_test.go | Comprehensive test coverage for new functionality including array handling and child entities |
| pkg/jira-datacenter/adapter_test.go | Integration tests for adapter with child entity scenarios |
| pkg/jira-datacenter/config.go | Minor optimization moving group map initialization outside loop |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dhanya-sgnl
requested changes
Sep 17, 2025
Contributor
dhanya-sgnl
left a comment
There was a problem hiding this comment.
LGTM overall but I had one request and one nit.
Collaborator
Author
|
FYI..PR #140, needs to be merged to fix some of the int64/float changes in the framework. Some of the tests are failing as result of that. |
dhanya-sgnl
previously approved these changes
Sep 17, 2025
dhanya-sgnl
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
API References
Pull request intention
Pull request checklist