Skip to content

feat: Add filtering and ordering support to GitHub Adapter #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aj-chandel wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Add filtering and ordering support to GitHub Adapter #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e94570
feat: Add filtering and ordering support to GitHub Adapter
claude[bot] May 28, 2025
fa655c7
feat: Add GetPage API tests for filtering and ordering functionality
claude[bot] May 28, 2025
9358c19
fix: Fix query builder parameter bugs and enhance GetPage test coverage
claude[bot] May 29, 2025
23d6467
test: Add test case for IssueAssigneeQueryBuilder parameter fix
claude[bot] May 29, 2025
b43cd4f
feat: Add comprehensive timestamp verification tests for order-by fun…
claude[bot] May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/github/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,19 @@ func (a *Adapter) RequestPageFromDatasource(
return framework.NewGetPageResponseError(err)
}

// Get entity-specific filter and ordering from config
var filter, orderBy *string
if request.Config.Filters != nil {
if filterValue, exists := request.Config.Filters[request.Entity.ExternalId]; exists && filterValue != "" {
filter = &filterValue
}
}
if request.Config.OrderBy != nil {
if orderByValue, exists := request.Config.OrderBy[request.Entity.ExternalId]; exists && orderByValue != "" {
orderBy = &orderByValue
}
}

githubReq := &Request{
BaseURL: request.Address,
Token: request.Auth.HTTPAuthorization,
Expand All @@ -70,6 +83,8 @@ func (a *Adapter) RequestPageFromDatasource(
PageSize: request.PageSize,
Organizations: request.Config.Organizations,
RequestTimeoutSeconds: *commonConfig.RequestTimeoutSeconds,
Filter: filter,
OrderBy: orderBy,
}

resp, err := a.GithubClient.GetPage(ctx, githubReq)
Expand Down
Loading
Loading