Skip to content

DDS-3046 - reduce logging level when validating user certificates #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Johxzu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DDS-3046 - reduce logging level when validating user certificates #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.3.12</version>
<version>1.2.13</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/ee/sk/mid/MidAuthenticationResponseValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ private boolean isCertificateTrusted(X509Certificate certificate) {
certificate.verify(trustedCACertificate.getPublicKey());
return true;
} catch (GeneralSecurityException e) {
logger.warn("Error verifying signer's certificate: " + certificate.getSubjectDN() + " against CA certificate: " + trustedCACertificate.getSubjectDN(), e);
logger.debug("Error verifying signer's certificate: " + certificate.getSubjectDN() + " against CA certificate: " + trustedCACertificate.getSubjectDN(), e);
}
}
return false;
Expand Down
37 changes: 37 additions & 0 deletions src/test/java/ee/sk/mid/AuthenticationResponseValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,17 @@
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;

import java.util.Arrays;
import java.security.cert.X509Certificate;
import java.util.Collections;

import ch.qos.logback.classic.Level;
import ch.qos.logback.classic.Logger;
import ch.qos.logback.classic.spi.ILoggingEvent;
import ch.qos.logback.core.read.ListAppender;
import ee.sk.mid.exception.MidInternalErrorException;
import org.junit.Test;
import org.slf4j.LoggerFactory;

public class AuthenticationResponseValidatorTest {

Expand Down Expand Up @@ -95,6 +101,37 @@ public void validate_whenCertificateNotTrusted_shouldReturnCertificateNotTrusted
assertThat(authenticationResult.getErrors(), hasItem(equalTo("Certificate that was returned is not signed by CA that is configured as trusted in mid-rest-java-client")));
}

@Test
public void validate_whenTrustedCaIterationFailsInitially_shouldLogAtDebugLevel() {
X509Certificate wrongCaCertificate = fileToX509Certificate("/trusted_certificates/TEST_of_ESTEID-SK_2011.pem.crt");
X509Certificate correctCaCertificate = fileToX509Certificate("/trusted_certificates/TEST_of_ESTEID-SK_2015.pem.crt");
MidAuthenticationResponseValidator validator = new MidAuthenticationResponseValidator(Arrays.asList(wrongCaCertificate, correctCaCertificate));

Logger validatorLogger = (Logger) LoggerFactory.getLogger(MidAuthenticationResponseValidator.class);
Level previousLevel = validatorLogger.getLevel();
validatorLogger.setLevel(Level.DEBUG);
ListAppender<ILoggingEvent> listAppender = new ListAppender<>();
listAppender.start();
validatorLogger.addAppender(listAppender);
try {
MidAuthenticationResult authenticationResult = validator.validate(createValidMobileIdAuthentication());
assertThat(authenticationResult.isValid(), is(true));
} finally {
validatorLogger.detachAppender(listAppender);
validatorLogger.setLevel(previousLevel);
}

boolean hasDebugLog = listAppender.list.stream()
.anyMatch(event -> event.getLevel().equals(Level.DEBUG)
&& event.getFormattedMessage().contains("Error verifying signer's certificate"));
boolean hasWarnLog = listAppender.list.stream()
.anyMatch(event -> event.getLevel().equals(Level.WARN)
&& event.getFormattedMessage().contains("Error verifying signer's certificate"));

assertThat(hasDebugLog, is(true));
assertThat(hasWarnLog, is(false));
}

@Test
public void validate_whenResultLowerCase_shouldReturnValidAuthenticationResult() throws Exception {
MidAuthentication authentication = MidAuthentication.newBuilder()
Expand Down