Skip to content

Conversation

@LeeHayun
Copy link
Member

Revert release.yml

@LeeHayun LeeHayun requested a review from Copilot June 27, 2025 20:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the release workflow to reinstate platform-specific packaging and adjusts build-trigger paths by removing the legacy cross-build workflow.

  • Restores detailed release.yml jobs for macOS (arm64/x64), various Windows backends (CPU, CUDA, SYCL, HIP), and iOS.
  • Updates build.yml path filters to drop references to the removed cross-compilation workflow.
  • Deletes the obsolete build-linux-cross.yml file.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/release.yml Re-added platform-specific release jobs and updated job dependencies
.github/workflows/build.yml Adjusted GitHub Actions path filters for build triggers
.github/workflows/build-linux-cross.yml Removed legacy cross-compilation workflow
Comments suppressed due to low confidence (3)

.github/workflows/release.yml:24

  • [nitpick] The macOS-arm64 and macOS-x64 jobs share nearly identical steps; consider consolidating them into a single matrix to reduce duplication and simplify maintenance.
  macOS-arm64:

.github/workflows/release.yml:267

  • [nitpick] The fallback value 'win64a' for ARM64 may be unclear—verify that this is the intended identifier for your curl setup action, or consider renaming for clarity.
          architecture: ${{ matrix.arch == 'x64' && 'win64' || 'win64a' }}

.github/workflows/release.yml:560

  • PowerShell does not expand wildcards inside single-quoted paths, so this invocation will fail. Use Get-ChildItem or resolve the exact ROCm path before calling clang.exe.
          & 'C:\Program Files\AMD\ROCm\*\bin\clang.exe' --version

- name: Build
id: cmake_build
run: |
sysctl -a
Copy link

Copilot AI Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running sysctl -a prints all system parameters and clutters the logs; consider removing it or narrowing the output to only necessary fields.

Suggested change
sysctl -a

Copilot uses AI. Check for mistakes.
@LeeHayun LeeHayun merged commit 391ab02 into SKKU-ESLAB:master Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant