Skip to content

Fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SLandoL wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2cc2f0
TorpedoStore_Exception_fix
Oct 15, 2025
883e61b
TorpedoStore_Random_Generator_fix
Oct 15, 2025
1a0f798
TorpedoStore_Operator_fix
Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/hu/bme/mit/spaceship/TorpedoStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,21 @@ public TorpedoStore(int numberOfTorpedos){
}
}

private Random generator = new Random();

public boolean fire(int numberOfTorpedos){
if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){
new IllegalArgumentException("numberOfTorpedos");
throw new IllegalArgumentException("numberOfTorpedos");
}

boolean success = false;

// simulate random overheating of the launcher bay which prevents firing
Random generator = new Random();
double r = generator.nextDouble();

if (r >= FAILURE_RATE) {
// successful firing
this.torpedoCount =- numberOfTorpedos;
this.torpedoCount -= numberOfTorpedos;
success = true;
} else {
// simulated failure
Expand Down
Loading