Conversation
…silence `useEffect` dependency warnings, and remove unused code.
There was a problem hiding this comment.
Pull request overview
This PR addresses ESLint warnings across the codebase by: (1) globally disabling the react-native/no-inline-styles rule and downgrading @typescript-eslint/no-unused-vars to a warning (with an ignore pattern for _-prefixed names), (2) adding // eslint-disable-next-line react-hooks/exhaustive-deps comments to intentional one-shot or scope-limited useEffect calls, and (3) removing genuinely unused code (imports, variables, and state).
Changes:
- Configure
.eslintrc.jsto turn off inline-style warnings and soften unused-variable errors. - Add
eslint-disable-next-linecomments to silence intentionaluseEffectdependency warnings across multiple screens and components. - Remove unused imports (
Image,Shield,Lock,DimensionsdestructorSCREEN_HEIGHT), an unusedisSecurestate, and unusedSTATUS_ORDER/TaskStatusdefinitions; addsetTaskStatusto theGlobalCelebrationeffect dependency array.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.eslintrc.js |
Adds two new rules: disables inline-style warnings and configures unused-vars as a warning |
src/components/BottomSheet.tsx |
Removes the unused SCREEN_HEIGHT constant (but leaves Dimensions import orphaned) |
src/components/PrivacyStatus.tsx |
Removes unused isSecure state and Shield/Lock icon imports |
src/components/TaskCard.tsx |
Removes unused Image import |
src/components/TaskDetailsInfo.tsx |
Removes locally-unused STATUS_ORDER/TaskStatus; replaces with explanatory comment |
src/components/GlobalCelebration.tsx |
Adds setTaskStatus to useEffect dependency array |
src/components/ChooseDestinationBottomSheet.tsx |
Adds eslint-disable comment for intentional deps omission |
src/components/AddTaskBottomSheet.tsx |
Adds eslint-disable comment for intentional deps omission |
src/screens/FocusScreen.tsx |
Adds eslint-disable comments for three intentional deps omissions |
src/screens/FocusSetupScreen.tsx |
Adds eslint-disable comment for run-once animation effect |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…dix to parseInt calls, and updated regex for YouTube URLs.
…transform patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…silence
useEffectdependency warnings, and remove unused code.