Skip to content

Added pyproject with dependencies#24

Closed
Th0ught09 wants to merge 49 commits intoSMLP-Systems:masterfrom
Th0ught09:dev
Closed

Added pyproject with dependencies#24
Th0ught09 wants to merge 49 commits intoSMLP-Systems:masterfrom
Th0ught09:dev

Conversation

@Th0ught09
Copy link
Collaborator

Added pyproject file with dependencies

uv.lock to ensure to conflicting installs

.python-version to ensure same python file used

@Th0ught09 Th0ught09 marked this pull request as draft October 16, 2025 10:32
@Th0ught09 Th0ught09 marked this pull request as ready for review October 16, 2025 10:34
@fbrausse
Copy link
Collaborator

uv.lock to ensure to conflicting installs

In general looks good to me, could you please also provide the command used to generate this uv.lock file so we can update it when need arises?

@fbrausse
Copy link
Collaborator

PS: Are the dependencies you specified in the pyproject.toml enough for you to successfully run the regression suite or do we need more packages?

If you run into any errors/issues with that, please let us know! And thank you for the PR!

@Th0ught09
Copy link
Collaborator Author

Th0ught09 commented Oct 20, 2025

PS: Are the dependencies you specified in the pyproject.toml enough for you to successfully run the regression suite or do we need more packages?

That's correct yes

In general looks good to me, could you please also provide the command used to generate this uv.lock file so we can update it when need arises?

uv lock --upgrade according to the documentation, I can make a separate pr that updates the README with this info if you'd like, as well as a way to install into an isolated environment :)

I've also seen there is a (somewhat stale) pr on using yapf, I can introduce a ruff formatter if you think that would be useful for code quality (it may involve a fairly big initial pr as it parses the origional files)

@fbrausse
Copy link
Collaborator

  1. I noticed that you put (some of?) Neel's PR into this PR now. I'd suggest to split these two changes: to keep this PR for the project metadata changes (uv.lock and .python-version) and open a separate PR for each task you're solving. You could even open a new issue here on Github for each such task, if you think that's helpful in structuring your work.
  2. These new tests and their .json descriptions should probably not go into the top-level directory of the SMLP project. Would it be possible to move them somewhere within the existing structure in the regr_smlp subdirectory? They could for instance be put into a separate subdir in there, to separate them from the existing tests.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave out NixOS-specific files from this PR, please.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about putting NixOS-specific files and instructions into a separate directory, e.g., doc/nixos? The flake file you used to build and install utils/poly from #29 (comment) could go there as well.

@Th0ught09
Copy link
Collaborator Author

  1. I noticed that you put (some of?) Neel's PR into this PR now. I'd suggest to split these two changes: to keep this PR for the project metadata changes (uv.lock and .python-version) and open a separate PR for each task you're solving. You could even open a new issue here on Github for each such task, if you think that's helpful in structuring your work.

    1. These new tests and their .json descriptions should probably not go into the top-level directory of the SMLP project. Would it be possible to move them somewhere within the existing structure in the regr_smlp subdirectory? They could for instance be put into a separate subdir in there, to separate them from the existing tests.

This was entirely accidental sorry, I'd forgotten this was a pr and I was experimenting on this branch for my third year project. I'll close the pr to stop the notifications but I will use your comments when opening a new one with this pr's origional intentions :)

@Th0ught09 Th0ught09 closed this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants