Skip to content

Add footnote and note numbering to Tables#399

Draft
SteveLLamb wants to merge 3 commits intomainfrom
issue/0374-5-tablenotes
Draft

Add footnote and note numbering to Tables#399
SteveLLamb wants to merge 3 commits intomainfrom
issue/0374-5-tablenotes

Conversation

@SteveLLamb
Copy link
Member

Closes #374, closes #375

@github-actions
Copy link

@thomasheritage
Copy link
Collaborator

Thanks a lot @SteveLLamb -- from a quick test this seems to be working well for notes and footnotes in Tables.

A couple of things:

  • In testing, I edit Table 1 to include a reference to a footnote defined in Table 2. This should be prohibited. In the rendering, Table 1 includes <sup><a href="#fn-doc-example"></a></sup> -- that is, the html for the link has been included but is empty and so is invisible. No in-browser error is displayed.
  • Now that "notes to tables" are supported, it would be useful to provide some guidance in the html-pub documentation about where to put them -- I assume that a table-wide note should go into <tfoot><tr><td> i.e. alongside any footnotes. Perhaps the footnotes example in "7.4.10 Tables" could be updated to also include a table-wide note alongside the footnote? (in fact, any Notes have to come just before footnotes according to ISO -- see this example)

@SteveLLamb
Copy link
Member Author

@thomasheritage ah yes, cool, have only <tfoot> validation on footnote, but i need to add in "self containment" validation too.

I will look at more guidance on the documentation for notes as well.

Great feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for footnotes (?) (at least "footnotes to tables") Notes to tables: numbering must restart for each new table

3 participants