Added Marley Script #405
Added Marley Script #405
Conversation
Script to create a tarfile containing MARLEY config files from a particular SN model
JostMigenda
left a comment
JostMigenda
left a comment
There was a problem hiding this comment.
I’ve noticed one subtle issue which could give wrong results (by some orders of magnitude), plus a few other bits of feedback. See the individual comments for details.
By the way, have we heard back from the MARLEY user(s) who wanted to test this? It would be good to get their feedback and confirm it works before we merge this.
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Implemented Jost's suggestions
|
We may have to force this merge with the main branch. The notebooks are still causing failures. |
JostMigenda
left a comment
JostMigenda
left a comment
There was a problem hiding this comment.
All my comments are resolved.
I’d still prefer to wait for feedback from actual MARLEY users; but if they continue to be unresponsive for the next few weeks, at some point we can just go ahead and merge this as is.
Updated script after getting feedback from Yun-Tse Tsai. The script now inserts into the MARLEY config files all the info MARLEY needs to run
|
I implemented the feedback I got from Yun-Tse Tsai and now the script inserts all the pieces into the config files that MARLEY needs. |
Script to create a tarfile containing MARLEY config files from a particular SN model