-
Notifications
You must be signed in to change notification settings - Fork 4
[지현] 과제 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doreming16
wants to merge
39
commits into
SSA-FE:main
Choose a base branch
from
doreming16:refac/JH
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[지현] 과제 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 과제
리팩토링 사항 정리 & 리팩토링 진행
내용들을 공부 ... 는 했으나 적용해보기에 엄두가 안났습니다 ㅠ.ㅠㅠ벌금 달게 받겠습니다
## ✏ 리팩토링 사항 정리 - 스장님께 검토 받았습니다
추가 공부해볼 것
-- in BaseHeader.tsx
-- 상태관리를 썼으면 좋았을 것 같다 -> 무슨 말일까.. ?! 공부해보기
고쳐볼 것
-- 세은민혁 팀처럼 아예 각각 특정한 모달을 설정해두고
-- 그 모달 컴포넌트 자체를 불러온다는 의미일까???
📖 Modal 중심 레퍼런스
📚 참고했던 레퍼런스들
https://www.freecodecamp.org/korean/news/cobojareul-wihan-riaegteu-context-wanbyeog-gaideu-2021/
https://velog.io/@velopert/react-portals
https://leetrue.hashnode.dev/component-lab-modal