차민혁 과제 제출 #2 #7
Open
차민혁 과제 제출 #2 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Routes> | ||
| <Route path="/" element={<Home />} /> | ||
| <Route path="/main" element={<Main />} /> | ||
| <Route path="/test" element={<ProtectedRoute isAuthenticated={isAuthenticated}><Test/></ProtectedRoute>} /> |
Member
There was a problem hiding this comment.
setIsButtonDisabled 로직이 너무 산재해요
조금 정리가 필요해보여
Member
There was a problem hiding this comment.
작동 잘하는 좋은 레거시로 잘 알아본거같아 !
내가 실무에서 이렇게 쓰이면 그대로 쓸거같은데
연습겸 한번 함수형으로 만들어보는거 추천 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
SSAFE LOGIN Pull Request
작업 내용
어떤 변경 사항이 있나요?
작업 예정