Skip to content

SOEOPS-798: add empty string check for spotlight quotes #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imonroe wants to merge 1 commit into
base: 12.x
Choose a base branch
from
Open

SOEOPS-798: add empty string check for spotlight quotes #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/engineering_profile_helper/engineering_profile_helper.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ function _engineering_profile_helper_trim_spotlight_quote(string $quote) {
}

function _engineering_profile_helper_modify_spotlight_quote_for_magazine(string $html): string {
// Return early if the HTML is empty to avoid DOMDocument ValueError in PHP 8.1+.
if (empty(trim($html))) {
return '';
}

$doc = new DOMDocument();

// Load the HTML fragment without adding <html> and <body>
Expand Down
Loading