Skip to content

Conversation

@rebeccahongsf
Copy link
Contributor

READY FOR REVIEW

Summary

  • SOEOPSFY24-558 | fixup footer link colors

Review By (Date)

  • April 1

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch

  2. Rebuild Cache and import config drush cr ; drush ci

  3. Navigate to site preview

  4. Verify that the footer links have red arrows by default; black arrows on hocus:
    image

  5. Review code

Associated Issues and/or People

  • SOEOPSFY24-558

@rebeccahongsf rebeccahongsf requested a review from imonroe April 8, 2025 18:11
@github-actions github-actions bot added the size/s label Apr 8, 2025
Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so there's nothing wrong with these changes, but this is going to be the wrong repo for them.
Note that this repo hasn't had a new tag since May of 2022. At that point, we move the theme into the profile. See also: https://github.com/SU-SOE/soe_profile/tree/11.x/themes/soe_basic

You'll see in the soe_profile repo, we no longer call for this dependency in the composer.json file, in lieu of the one in the profile already.

Would you mind moving this to the soe_profile repo, within the themes/soe_basic directory? Otherwise, it'll never get deployed.

In other news, when Mike gets back from vacation, let's have a conversation about archiving this repo or something, just to avoid confusion.

@rebeccahongsf
Copy link
Contributor Author

Ok, so there's nothing wrong with these changes, but this is going to be the wrong repo for them. Note that this repo hasn't had a new tag since May of 2022. At that point, we move the theme into the profile. See also: https://github.com/SU-SOE/soe_profile/tree/11.x/themes/soe_basic

You'll see in the soe_profile repo, we no longer call for this dependency in the composer.json file, in lieu of the one in the profile already.

Would you mind moving this to the soe_profile repo, within the themes/soe_basic directory? Otherwise, it'll never get deployed.

In other news, when Mike gets back from vacation, let's have a conversation about archiving this repo or something, just to avoid confusion.

Ah! That makes so much more sense, especially for the reasoning behind why past Rebecca originally opened it up in the soe_profile repo. 😄 I reopened the old PR here: SU-SOE/soe_profile#319

Thanks @imonroe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants