Added support for LLVM 20.1.0 and fix .editorconfig glob pattern for Vim by bsdb0y · Pull Request #1685 · SVF-tools/SVF

bsdb0y · 2025-04-05T10:33:00Z

No description provided.

codecov · 2025-04-05T10:49:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (8161e7a) to head (4ef0d18).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1685   +/-   ##
=======================================
  Coverage   63.59%   63.59%           
=======================================
  Files         244      244           
  Lines       25736    25736           
  Branches     4508     4508           
=======================================
  Hits        16366    16366           
  Misses       9370     9370

Files with missing lines	Coverage Δ
svf-llvm/include/SVF-LLVM/BreakConstantExpr.h	`33.33% <ø> (ø)`
svf-llvm/include/SVF-LLVM/LLVMUtil.h	`76.27% <ø> (ø)`
svf-llvm/lib/LLVMModule.cpp	`75.47% <ø> (ø)`
svf-llvm/lib/LLVMUtil.cpp	`73.80% <ø> (ø)`
svf-llvm/lib/SVFIRBuilder.cpp	`86.79% <ø> (ø)`
svf-llvm/tools/Example/svf-ex.cpp	`95.45% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yuleisui · 2025-04-05T10:53:54Z

Thanks for your contribution.

It would be good to support a more stable version of LLVM.20.1.0.

Could you also change the buid.sh for the CI to trigger the build of svf on top of new LLVM here?

SVF/build.sh

Line 26 in 1f7fcb8

MajorLLVMVer=16

bsdb0y · 2025-04-05T11:01:27Z

done, in the build.sh I have added 20.1.0 as stable.

yuleisui · 2025-04-05T11:04:22Z

done, in the build.sh I have added 20.1.0 as stable.

Looks like brew install llvm@20 is not available. It might need a few iterations to update the build.sh and github actions to fix these configuration errors.

bsdb0y · 2025-04-05T11:08:19Z

done, in the build.sh I have added 20.1.0 as stable.

Looks like brew install llvm@20 is not available. It might need a few iterations to update the build.sh and github actions to fix these configuration errors.

Tested with LLVM 19.1.7 - compilation is working fine. Let me know if anything else is required on my end.
My Environment:

root@e857b7fe3f28:~/SVF# cat /etc/os-release
PRETTY_NAME="Ubuntu Plucky Puffin (development branch)"
NAME="Ubuntu"
VERSION_ID="25.04"
VERSION="25.04 (Plucky Puffin)"
VERSION_CODENAME=plucky
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=plucky
LOGO=ubuntu-logo

yuleisui · 2025-04-05T11:18:26Z

done, in the build.sh I have added 20.1.0 as stable.

Looks like brew install llvm@20 is not available. It might need a few iterations to update the build.sh and github actions to fix these configuration errors.

Tested with LLVM 19.1.7 - compilation is working fine. Let me know if anything else is required on my end. My Environment:
root@e857b7fe3f28:~/SVF# cat /etc/os-release
PRETTY_NAME="Ubuntu Plucky Puffin (development branch)"
NAME="Ubuntu"
VERSION_ID="25.04"
VERSION="25.04 (Plucky Puffin)"
VERSION_CODENAME=plucky
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=plucky
LOGO=ubuntu-logo

Could you then update the build.sh and github action?

…lure handling

bsdb0y · 2025-04-05T13:31:44Z

done, in the build.sh I have added 20.1.0 as stable.

Looks like brew install llvm@20 is not available. It might need a few iterations to update the build.sh and github actions to fix these configuration errors.

On Mac OS - Sequoia 15.3.2:

$ brew list --versions llvm@20 && clang --version && llvm-config --version  && uname -a && sw_vers && xcodebuild -version
llvm 20.1.1
clang version 20.0.0git (https://github.com/llvm/llvm-project.git 2e30df740ef0b9f8edb7075768540ce08678023d)
Target: arm64-apple-darwin24.3.0
Thread model: posix
InstalledDir: /usr/local/bin
20.0.0git
Darwin test-2.local 24.3.0 Darwin Kernel Version 24.3.0: Thu Jan  2 20:24:16 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T6000 arm64
ProductName:            macOS
ProductVersion:         15.3.2
BuildVersion:           24D81
Xcode 16.2
Build version 16C5032a

bsdb0y · 2025-04-05T13:51:49Z

done, in the build.sh I have added 20.1.0 as stable.

Looks like brew install llvm@20 is not available. It might need a few iterations to update the build.sh and github actions to fix these configuration errors.

Tested with LLVM 19.1.7 - compilation is working fine. Let me know if anything else is required on my end. My Environment:
root@e857b7fe3f28:~/SVF# cat /etc/os-release
PRETTY_NAME="Ubuntu Plucky Puffin (development branch)"
NAME="Ubuntu"
VERSION_ID="25.04"
VERSION="25.04 (Plucky Puffin)"
VERSION_CODENAME=plucky
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=plucky
LOGO=ubuntu-logo
Could you then update the build.sh and github action?

build.sh:

Added a fallback mechanism to install Clang+LLVM via apt if the curl download fails.
Introduced additional checks to validate the curl download process.

GitHub Actions:

The workflow is getting cancelled -- possibly due to it taking too long.
Is there a recommended way to test the workflow locally before pushing?

currently, trying act tool to replicate github actions workflow.
https://github.com/nektos/act

bsdb0y · 2025-04-06T16:01:02Z

Currently, the tests are failing because the Test-Suite still has old .bc files that were built with LLVM 16. I ran the generate_bc.sh script with LLVM20 to rebuild everything, and that fixed about 98% of the test failures. There are still a few tests failing, and I’m working on fixing those. bsdb0y/Test-Suite@cbce00e

Could you help me figure out how to run generate_bc.sh in GitHub Actions? I tried adding it to the build-svf step after build.sh, but it didn’t work as expected.

…untu-steps

van-ema · 2025-04-07T14:36:11Z

I get errors during linking of svf-llvm.
To fix we can force dynamic linking of passes component that includes the PassBuilder

I'm building with llvm 19.1.4

See bsdb0y@df92120

bsdb0y · 2025-04-22T17:30:49Z

@yuleisui
before we can properly test the changes in this PR with GitHub Actions, I kindly request that we first review and merge the following Test-Suite PR: SVF-tools/Test-Suite#156.

It updates the test suite to be compatible with LLVM 20 and ensures all tests run correctly. Merging it first will help us get accurate test results here.

yuleisui · 2025-04-23T01:34:44Z

@yuleisui before we can properly test the changes in this PR with GitHub Actions, I kindly request that we first review and merge the following Test-Suite PR: SVF-tools/Test-Suite#156.

It updates the test suite to be compatible with LLVM 20 and ensures all tests run correctly. Merging it first will help us get accurate test results here.

Could you clean up your pull request in test-suite? There are lots of svf.svf.bc files and pre.bc files committed. Please make sure the commit is clean with mimum changes.

bsdb0y · 2025-04-23T05:34:41Z

@yuleisui before we can properly test the changes in this PR with GitHub Actions, I kindly request that we first review and merge the following Test-Suite PR: SVF-tools/Test-Suite#156.
It updates the test suite to be compatible with LLVM 20 and ensures all tests run correctly. Merging it first will help us get accurate test results here.

Could you clean up your pull request in test-suite? There are lots of svf.svf.bc files and pre.bc files committed. Please make sure the commit is clean with mimum changes.

Thank you for pointing that out! I had pushed the precompiled .bc files as we are using them, but I mistakenly forgot to clean up the .pre. and *.svf.bc files. I've already made the suggested changes and cleaned up the pull request to ensure it includes only the relevant files. Please let me know if there’s anything else I can do or adjust to make it merge.

bsdb0y · 2025-04-24T06:32:02Z

I get errors during linking of svf-llvm. To fix we can force dynamic linking of passes component that includes the PassBuilder

I'm building with llvm 19.1.4

See bsdb0y@df92120

thank you so much @van-ema for testing it on macOS. I have added a check for OS detection to CMakeLists.txt, so it is like: if macOS, then add passes to link bsdb0y@cb7bb31

bsdb0y · 2025-05-04T06:07:49Z

@yuleisui could you please approve the latest commit so we can confirm whether it's failing or success? It’s working perfectly on my end, I tested it locally on both Ubuntu and macOS, even using the act tool to simulate GitHub Actions. I’m happy to integrate this work if everything works out. Let me know if you need anything from my side!

bsdb0y · 2025-05-04T06:25:28Z

@yuleisui could you please approve the latest commit so we can confirm whether it's failing or success? It’s working perfectly on my end, I tested it locally on both Ubuntu and macOS, even using the act tool to simulate GitHub Actions. I’m happy to integrate this work if everything works out. Let me know if you need anything from my side!

@yuleisui I can see from the GitHub Actions that the code is compiling successfully on both environments, but the tests are failing. That’s because this PR (SVF-tools/Test-Suite#156) still needs to be reviewed, approved, and merged. Once that happens, it should fetch the latest test cases that are compatible with LLVM 20.

bernardnongpoh · 2025-06-09T18:02:14Z

@yuleisui could you please approve the latest commit so we can confirm whether it's failing or success? It’s working perfectly on my end, I tested it locally on both Ubuntu and macOS, even using the act tool to simulate GitHub Actions. I’m happy to integrate this work if everything works out. Let me know if you need anything from my side!

@yuleisui I can see from the GitHub Actions that the code is compiling successfully on both environments, but the tests are failing. That’s because this PR (SVF-tools/Test-Suite#156) still needs to be reviewed, approved, and merged. Once that happens, it should fetch the latest test cases that are compatible with LLVM 20.

@yuleisui could kindly merge this request. It seems the testcases that are failing are from the Test-Suite.

yuleisui · 2025-06-10T00:27:59Z

@yuleisui could you please approve the latest commit so we can confirm whether it's failing or success? It’s working perfectly on my end, I tested it locally on both Ubuntu and macOS, even using the act tool to simulate GitHub Actions. I’m happy to integrate this work if everything works out. Let me know if you need anything from my side!

@yuleisui I can see from the GitHub Actions that the code is compiling successfully on both environments, but the tests are failing. That’s because this PR (SVF-tools/Test-Suite#156) still needs to be reviewed, approved, and merged. Once that happens, it should fetch the latest test cases that are compatible with LLVM 20.

@yuleisui could kindly merge this request. It seems the testcases that are failing are from the Test-Suite.

@bernardnongpoh thanks for your contributions. I have left comments in test-suite as the bc files are auto generated using scripts configured by github actions, they are not supposed to be part of the pull request.

SVF-tools/Test-Suite#156

Adapt SVF to build against LLVM 22, following ideas from PR SVF-tools#1685. Build/setup: - build.sh: bump MajorLLVMVer 18 -> 22, point Linux tarballs at bjjwwang/SVF-LLVM 22.1.0 releases (x86_64 and aarch64). - setup.sh: LLVM_DIR -> llvm-22.1.0.obj. LLVM 22 API migration: - BasicTypes.h: guard removed Atomic{Mem,MemSet,MemTransfer,MemCpy, MemMove}Intrinsic and MemCpyInlineInst typedefs under LLVM_VERSION_MAJOR < 22. - LLVMUtil.h: getDataLayout() now returns const DataLayout* via Module::getDataLayout() on LLVM >= 22 (DataLayout(Module*) removed). - LLVMModule.cpp: replace StringRef::equals() with operator== (4 sites). - LLVMUtil.cpp: use findDVRDeclares + DbgVariableRecord on LLVM >= 22 (findDbgDeclares signature changed). - SVFIRBuilder.cpp: adapt computeGepOffset to const DataLayout*. - svf-ex.cpp: skip llvm_shutdown() on LLVM >= 22. Semantic fixes for new clang codegen: - Options.cpp: default FirstFieldEqBase to true. LLVM 22 clang more often emits opaque-pointer GEPs that collapse base and first field; keeping them equivalent avoids spurious NOALIAS/false positives. - AEDetector.cpp: handle BaseObjVar in updateGepObjOffsetFromBase so GEP results that fold to the base under ff-eq-base are treated as offset 0 instead of asserting. - PointerAnalysisImpl.cpp: skip base->fields expansion in expandFIObjs when FirstFieldEqBase is on, preserving the equivalence. - SVFIRBuilder.cpp (InitialGlobal): detect [N x i8] padding fields in anonymous literal struct initializers and skip them so logical field indices stay aligned with access-side GEPs. Test results on Test-Suite (Debug-build ctest, -j 1): 92% passed, 1720/1879. Remaining 159 failures are 155 ae_semi_sparse (upstream incomplete feature) and 4 cfl_tests on one arraycopy1.c.bc file (pre-existing CFL grammar limitation, not LLVM 22 related).

bsdb0y added 3 commits April 5, 2025 15:54

Added support for LLVM 20.1.1 and fix .editorconfig glob pattern for Vim

360319a

removed trash files

adccd33

removed tags file

4ef0d18

Bumped LLVM from 16.0.4 to 20.1.0

e052881

bsdb0y changed the title ~~Added support for LLVM 20.1.1 and fix .editorconfig glob pattern for Vim~~ Added support for LLVM 20.1.0 and fix .editorconfig glob pattern for Vim Apr 5, 2025

bsdb0y added 3 commits April 5, 2025 17:35

updated ubuntu-step for clang+llvm+llvm-config-20

45be3be

added APT fallback for clang+llvm and curl+wget improved download fai…

0f17522

…lure handling

updated repo for noble

caf4118

bsdb0y added 3 commits April 5, 2025 20:06

Cleaned up packages and updated LLVM version in CI

b3cfb86

darwin: added brew update and removed minor ver from CI

dced62f

Added strict mode, refined variables, and improved input handling

1643f95

bsdb0y added 2 commits April 6, 2025 22:53

Refactor: Move dependency installation to build.sh and clean up CI ub…

ad377e5

…untu-steps

updated prerequisite package list

fbb9099

added LLVM_DIR, CC and CXX

5cd5a8c

bsdb0y added 2 commits April 24, 2025 01:23

resolved memory leaks and updated env variables

d23551b

fixing macOS issues and envs

cb7bb31

added debug logs and script dirs

c4d0bf5

bsdb0y mentioned this pull request May 15, 2025

Updated the tests codes for llvm20 SVF-tools/Test-Suite#156

Open

bjjwwang mentioned this pull request Apr 14, 2026

Support LLVM 22.1.0, but 4 CFL cases cannot pass. (maybe no need to pass) #1811

Open

Conversation

bsdb0y commented Apr 5, 2025

Uh oh!

codecov Bot commented Apr 5, 2025

Codecov Report

Uh oh!

yuleisui commented Apr 5, 2025

Uh oh!

bsdb0y commented Apr 5, 2025

Uh oh!

yuleisui commented Apr 5, 2025

Uh oh!

bsdb0y commented Apr 5, 2025

Uh oh!

yuleisui commented Apr 5, 2025

Uh oh!

bsdb0y commented Apr 5, 2025

Uh oh!

bsdb0y commented Apr 5, 2025

Uh oh!

bsdb0y commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

van-ema commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bsdb0y commented Apr 22, 2025

Uh oh!

yuleisui commented Apr 23, 2025

Uh oh!

bsdb0y commented Apr 23, 2025

Uh oh!

bsdb0y commented Apr 24, 2025

Uh oh!

bsdb0y commented May 4, 2025

Uh oh!

bsdb0y commented May 4, 2025

Uh oh!

bernardnongpoh commented Jun 9, 2025

Uh oh!

yuleisui commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bsdb0y commented Apr 6, 2025 •

edited

Loading

van-ema commented Apr 7, 2025 •

edited

Loading