Fix missing push() before pop() in SaberCondAllocator::isSatisfiable#1816
Open
Patrickstarrrrr wants to merge 1 commit intoSVF-tools:masterfrom
Open
Fix missing push() before pop() in SaberCondAllocator::isSatisfiable#1816Patrickstarrrrr wants to merge 1 commit intoSVF-tools:masterfrom
Patrickstarrrrr wants to merge 1 commit intoSVF-tools:masterfrom
Conversation
The isSatisfiable function calls solver.pop() without a matching push(), which causes a Z3 'index out of bounds' exception when the solver's scope stack is empty. This also pollutes the solver state because the added constraint is never popped. Add the missing push() to match the existing pop(), consistent with the adjacent isEquivalentBranchCond() and Z3Expr.cpp usage patterns.
Patrickstarrrrr
force-pushed
the
fix-svf-bug
branch
from
58dcfc4 to
de7bee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
SaberCondAllocator::isSatisfiable()callssolver.pop()without a matchingsolver.push(). This causes a Z3 "index out of bounds" exception when the solver's scope stack is empty. Additionally, the added constraint is never popped, permanently polluting the solver state.Fix
Add the missing
push()beforeadd(), consistent with the adjacentisEquivalentBranchCond()and the usage pattern inZ3Expr.cpp.