ui : offline mode #359
Merged
ui : offline mode #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolph1
force-pushed
the
ui/offline-mode-ui
branch
from
6c753f6 to
4c3976c
Compare
|
MathisHage
approved these changes
Dec 20, 2024
Contributor
MathisHage
left a comment
MathisHage
left a comment
There was a problem hiding this comment.
The changes introduced fix a similar old unmerged PR discarded because of heavy version control issues. This has hence almost entirely already been reviewed previously (#348).
This was
linked to
issues
Dec 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short:
This PR significantly enhances the user interface and offline mode screen logic to have an overall better user experience. It finalizes the offline mode by adding dynamic screen changes along with definitive tests.
Files modified:
-
OfflineInterviewModule,OfflineInterviewModuleTest: Fixed the colors to match the theme and added a new box containing what part of the interview the interviewer should focus on.-
OfflineRecordingsProfile: is now cleaner and adapts to dark mode-
PreviousRecordingsFeedback,PreviousRecordingsFeedbackTest: is now cleaner, adapts to dark mode, contains what the user said and updates as soon as the GPT response is received by polling the cache.-
OfflinePromptsFunctions: Are now adapted to all the other screens' logic needs-
RecordingReviewScreen: Now adapts to dark modeLeaderBoard: there was a typo in the parametersSpeakingViewModel,ChatViewModel: the prompts are now adapted to ask GPT to mention the part of the interview to focus onOfflineRecordingScreenTest,OfflineRecordingScreen-,
MainActivity,Theme: A few themes have been added for the previous interview prompt cards' needs. MainActivity has been changed to adapt to the new parameters too.Files deleted:
-
OfflinePracticeQuestionsScreen,OfflinePracticeQuestionsScreenTest: These files are now redundant because of the outlined text box inOfflineInterviewModulewhich now include the question.In conclusion:
This PR heavily augments the offline mode to be a fully fledged finalized feature that works very well and is reactive, a lot of bugs and inconsistencies have been fixed too. Tests are not all that thorough mostly because of multithreading to poll the cache to update the feedback screen as soon as a response has been added.