Conversation
DoyoubK
reviewed
Apr 21, 2025
Contributor
DoyoubK
left a comment
DoyoubK
left a comment
There was a problem hiding this comment.
고생 많으셨습니다! 제가 리뷰를 너무 늦게 했네요 ㅠ
| this.jdbcTemplate = jdbcTemplate; | ||
| } | ||
|
|
||
| public void addCountry(Country country) { |
Contributor
There was a problem hiding this comment.
요거는 JPA 안쓰시고 JDBC 쓰신 이유가 있으실까요?
|
|
||
| private final String description; | ||
|
|
||
| public static Continent fromString(String value) { |
Contributor
There was a problem hiding this comment.
요거 호출 빈도가 높으면 메모리 사용량이 꽤 될거같아서, String - Continent 쌍으로 Map 저장해도 좋을거같아요!
Comment on lines
+24
to
+26
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "country_id", nullable = false) | ||
| private Country country; |
Contributor
There was a problem hiding this comment.
요건 개인적인 선호도인데... Join 을 명시적으로 안하고 코드 레벨에서 관리하면 어떨까 싶습니다. 회의할때 의견 나눠보시죵
Comment on lines
+102
to
+103
| Users user = userRepository.findUserWithTags(userNumber) | ||
| .orElseThrow(() -> new IllegalArgumentException("사용자를 찾을 수 없습니다.")); |
Contributor
There was a problem hiding this comment.
요거랑 위 calculateVisitedCountryCount 랑 순서 변경해야 안전할 듯 합니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Number
PR 유형
📝 작업 내용
🔖 리뷰 요구사항(선택)
✅ PR Check List