Optimize SQL query performance#1
Open
devin-ai-integration[bot] wants to merge 1 commit intodevelopfrom
Open
Conversation
- Add index on rooms.name to optimize LIKE queries in remove_rooms_by_name - Optimize award_bonus procedure to use single UPDATE instead of SELECT+UPDATE - Reduce database round trips and eliminate full table scans Co-Authored-By: sachet.agarwal@windsurf.com <sachet.agarwal@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize SQL query performance
Summary
This PR optimizes SQL query performance in the PL/SQL procedures through two main changes:
idx_rooms_nameindex to optimize LIKE queries inremove_rooms_by_nameprocedure, eliminating full table scansReview & Testing Checklist for Human
remove_rooms_by_namewith various LIKE patterns to verify the new index actually improves query performanceNotes
sql%rowcountto determine if the UPDATE affected any rows, then conditionally checks for null commission cases