Migrate from Java 11 to Java 17#10
Open
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Open
Conversation
- Update Java source/target compatibility from 11 to 17 - Upgrade Spring Boot from 2.6.3 to 2.7.18 - Update MyBatis Spring Boot Starter from 2.2.2 to 2.3.2 - Update Netflix DGS from 4.9.21 to 4.10.5 (compatible with Spring Boot 2.7.x) - Update SQLite JDBC from 3.36.0.3 to 3.45.1.0 - Update GitHub Actions workflow to use Java 17 with Temurin distribution Note: REST Assured kept at 4.5.1 to maintain test compatibility (5.x has breaking API changes) Co-Authored-By: sachet.agarwal@windsurf.com <sachet.agarwal@windsurf.com>
Author
Original prompt from sachet.agarwal2. Update Spring Boot VersionFile: Upgrade Spring Boot from version 2.6.3 to 2.7.18 (line 2): // Current:
id 'org.springframework.boot' version '2.6.3'
// Change to:
id 'org.springframework.boot' version '2.7.18'3. Update Key DependenciesFile: Update the following dependencies (lines 38-45):
// Current:
implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.2.2'
implementation(platform("com.netflix.graphql.dgs:graphql-dgs-platform-dependencies:4.9.21"))
runtimeOnly 'org.xerial:sqlite-jdbc:3.36.0.3'
implementation 'joda-time:joda-time:2.10.13'
// Change to:
implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.3.2'
implementation(platform("com.netflix.graphql.dgs:graphql-dgs-platform-dependencies:7.6.0"))
runtimeOnly 'org.xerial:sqlite-jdbc:3.45.0'
implementation 'joda-time:joda-time:2.10.13'4. Update Testing Dependencies... (1839 chars truncated...) |
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: sachet.agarwal@windsurf.com <sachet.agarwal@windsurf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Spring Boot RealWorld application from Java 11 to Java 17 using the conservative approach (Spring Boot 2.7.x) to maintain
javax.*package compatibility without requiring source code changes.Key changes:
runtimeOnly)Deviations from original request:
Updates since last revision
Review & Testing Checklist for Human
implementationtoruntimeOnlyis intentional and acceptable./gradlew bootRunand test basic functionality (e.g.,curl http://localhost:8080/tags)Recommended test plan:
./gradlew clean testlocally to verify all 68 tests pass./gradlew bootRunand test endpoints:/tags,/articles, user registration/graphqlis functionalNotes
All 68 tests pass locally with Java 17. CI is now passing. No source code changes were required since Spring Boot 2.7.x maintains
javax.*package compatibility.Link to Devin run: https://app.devin.ai/sessions/6ca877bdb446422e8a4a431656284f43
Requested by: @SachetCognition