Remove GraphQL implementation and migrate to REST-only architecture#4
Open
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Open
Remove GraphQL implementation and migrate to REST-only architecture#4devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Conversation
- Remove entire graphql package (resolvers, mutations, datafetchers)
- Remove GraphQL schema file (schema.graphqls)
- Remove Netflix DGS Framework dependency from build.gradle
- Remove DGS codegen plugin and generateJava task configuration
The REST API already covers all functionality that was in GraphQL:
- Articles CRUD operations (/articles endpoints)
- User authentication and management (/users endpoints)
- Profile operations (/profiles endpoints)
- Comments operations (/articles/{slug}/comments endpoints)
- Favorites operations (/articles/{slug}/favorite endpoints)
- Tags operations (/tags endpoint)
All 68 existing tests pass, confirming the REST API remains fully functional.
Co-Authored-By: sachet.agarwal@windsurf.com <sachet.agarwal@windsurf.com>
Author
Original prompt from sachet.agarwal |
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: sachet.agarwal@windsurf.com <sachet.agarwal@windsurf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove GraphQL implementation and migrate to REST-only architecture
Summary
This PR removes the entire GraphQL implementation from the Spring Boot RealWorld application, standardizing on REST API only. The application previously supported both REST and GraphQL APIs sharing the same underlying business logic.
Changes made:
io.spring.graphqlpackage (12 files including resolvers, mutations, and exception handlers)src/main/resources/schema/schema.graphqlsbuild.gradle:com.netflix.dgs.codegenplugin (v5.0.6)graphql-dgs-spring-boot-starterdependency (v4.9.21)generateJavatask configurationPreserved (not modified):
apipackage - REST controllersapplicationpackage - Application servicescorepackage - Domain entities and repository interfacesinfrastructurepackage - MyBatis implementationsUpdates since last revision
actions/cachefrom v2 to v4 (GitHub deprecated v2)Review & Testing Checklist for Human
./gradlew bootRun) - ensure no GraphQL auto-configuration issues occur/articles,/users,/profiles,/tagsendpoints)io.spring.graphqlimports)Recommended test plan:
./gradlew testto verify all 68 tests pass./gradlew bootRuncurl http://localhost:8080/tagsandcurl http://localhost:8080/articlesNotes
/tags,/articles, user registration) work correctlyLink to Devin run: https://app.devin.ai/sessions/b58e96a99a5c4e0eb02867c5a88640e2
Requested by: sachet.agarwal@windsurf.com (@SachetCognition)