Conversation
| TooltipLinkList, | ||
| TooltipLinkListLink, | ||
| } from "@storybook/components"; | ||
| } from "storybook/internal/components"; |
There was a problem hiding this comment.
question: the migration docs indicate anything moved to internal might be deprecated in v10, is this the right package to use here and if we have to do we have a ticket/plan for migrating off it asap?
There was a problem hiding this comment.
This is within our addon (version-picker) and the migration docs also mention:
"Addon authors may continue to use the internal packages, there is currently not yet any replacement."
I might create a ticket to keep an eye on it essentially, but not sure there's much that can be done right now other that rewrite all these components and make them internal for our Storybook only?
There was a problem hiding this comment.
suggestion: what do you think about adding a comment briefing explaining this and/or linking to the ticket once its raised?
Might be worth being clear Storybook only recommend addon authors use this API and it shouldn't be used elsewhere.
.storybook/manager.ts
Outdated
| import { ADDON_ID, TOOL_ID } from "./version-picker/constants"; | ||
| import { VersionPicker } from "./version-picker"; | ||
| import { API_PreparedIndexEntry, API_StatusObject } from "@storybook/types"; | ||
| import { API_PreparedIndexEntry } from "storybook/internal/types"; |
There was a problem hiding this comment.
Question: is this still needed? If it is, is it the appropriate type to use given that it's now internal?
nineteen88
force-pushed
the
FE-7277
branch
2 times, most recently
from
db4acba to
79d67fa
Compare
- change the way we hide stories to the documented method as per Storybook docs
nineteen88
force-pushed
the
FE-7277
branch
2 times, most recently
from
9976de6 to
6a5f8c6
Compare
|
Blocked until this is resolved storybookjs/storybook#32007 |
3 participants
Proposed behaviour
Current behaviour
Checklist
QA
Additional context
Testing instructions