fix(text-editor): move unit tests to playwright#7736
Open
mihai-albu-sage wants to merge 1 commit intomasterfrom
Open
fix(text-editor): move unit tests to playwright#7736mihai-albu-sage wants to merge 1 commit intomasterfrom
mihai-albu-sage wants to merge 1 commit intomasterfrom
Conversation
mihai-albu-sage
force-pushed
the
FE-7497
branch
2 times, most recently
from
63f84bf to
be9323e
Compare
mihai-albu-sage
force-pushed
the
FE-7497
branch
from
be9323e to
b379a47
Compare
| open={hyperlinkDialogOpen} | ||
| onCancel={ | ||
| /* istanbul ignore next */ () => { | ||
| // console.log('\n\n\n\n on cancel! \n\n\n\n') |
Contributor
There was a problem hiding this comment.
nitpick: Looks like some commented out code left here
Contributor
Author
There was a problem hiding this comment.
Removed the commented out row.
Contributor
paulrobinson88
left a comment
paulrobinson88
left a comment
There was a problem hiding this comment.
Hi Mihai, just a couple of questions on this, thanks.
src/components/text-editor/__internal__/__ui__/Toolbar/buttons/hyperlink.test.tsx
Outdated
Show resolved
Hide resolved
src/components/text-editor/__internal__/__ui__/Toolbar/buttons/hyperlink.test.tsx
Show resolved
Hide resolved
mihai-albu-sage
force-pushed
the
FE-7497
branch
from
b379a47 to
42a1e8d
Compare
mihai-albu-sage
force-pushed
the
FE-7497
branch
from
42a1e8d to
65f5c25
Compare
paulrobinson88
approved these changes
Feb 2, 2026
DipperTheDan
approved these changes
Feb 2, 2026
dariusbercea-sage
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The
TestEditorcomponent, which was introduced to support Jest unit tests forTextEditor, has been removed. Tests now useTextEditordirectly or wrap it withLexicalComposerwhere appropriate, while maintaining 100% code coverage.In addition, multiple Playwright tests have been added for
TextEditorto ensure its behavior is validated in a real browser environment. Some of the unit tests that were flaky and not required for the 100% code coverage have been moved to Playwright tests.Current behaviour
Currently, the
TestEditorcomponent is used to support Jest unit tests, however, this approach is not always ideal, as it relies on a simplified version of the actual component. The Playwright tests can be improved to cover more functionality even if there is some overlap with the jest unit tests.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions