build: remove babel, configure swc to be main test transpiler#7743
Open
tomdavies73 wants to merge 2 commits intomasterfrom
Open
build: remove babel, configure swc to be main test transpiler#7743tomdavies73 wants to merge 2 commits intomasterfrom
tomdavies73 wants to merge 2 commits intomasterfrom
Conversation
This removes all unused exports within the codebase which were not being directly imported or tested elsewhere. It also removes superfluous exports where a const is exported as both a named or default export If any exports cannot be removed because they are used in other files which are not directly tested, new tests have been added BREAKING CHANGE: If any consumers are importing any of these exports which have been removed this will break their application. In theory no consumers should be importing implementation details into their project, however we have marked this change as breaking as there is a very remote possibility that some projects could break due to this change
tomdavies73
added
the
Work in progress
edleeks87
reviewed
Jan 30, 2026
| import compareBuild from "semver/functions/compare-build"; | ||
|
|
||
| import { TOOL_ID } from "./constants"; | ||
| import { TOOL_ID } from "./constants/constants"; |
Contributor
There was a problem hiding this comment.
suggestion: you can just make constants.ts an index.ts
| return ( | ||
| <div ref={trapRef}> | ||
| {isOpen && ( | ||
| <div |
Contributor
There was a problem hiding this comment.
comment: not part of your changes but we should add the following to the top of the file imo so we don't get the linter warnings anymore
/* eslint-disable jsx-a11y/no-noninteractive-tabindex */
/* eslint-disable jsx-a11y/no-static-element-interactions */
| "<rootDir>/lib", | ||
| "<rootDir>/esm", | ||
| ".*index\\.ts$", | ||
| ".*[.-]config\\.ts$", |
Contributor
There was a problem hiding this comment.
comment: we're still including files that aren't needed in the coverage report
Contributor
There was a problem hiding this comment.
I think it's worth generating a report from a test run in master and comparing it to one from this PR
| } | ||
|
|
||
| export const ActionPopoverItem = ({ | ||
| const ActionPopoverItem = ({ |
Contributor
There was a problem hiding this comment.
comment: I think this change has broken the prop table for the sub-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Removes all
babelrelated dependencies and instead usesswc/jestas the main test transpiler. In order to transition toswc/jestsome additional changes have also been made.babel/jest's less aggressive tree-shaking meant it would often leave unused exports in place during transpilation.swc/jesttakes a stricter approach - it analyses exports more carefully and expects us to be more explicit about what we're exporting and using.All exports which are unused (not imported anywhere else internally) were highlighted and have had to be removed.
There were multiple instances of consts which were only used locally in one file being exported, or instances of some costs being exported and never being used locally or elsewhere.
In some files we have also "doubled up" our exports, exporting twice as a named export and a default export. Where possible the named export has been removed, and only the default export remains.
Some additional steps have been made to meet coverage requirements with some exports which are needed but not directly tested, as
instanbul ignoreis now ineffectual against uncovered const statementsThe removal of unused exports has been marked as a breaking change as technically some consumers may have imported these directly from legacy projects etc. However, the actual likelihood that this will break consumers' applications is slim to none.
config.tsandindex.tsfiles are now exempt from the coverage report, asconfig.tsconsts are typically used in stories and therefore are treated as unused.index.tsfiles exports are consumer facing entry points, so they have also been exempt as some exports are never imported and used elsewhere.Current behaviour
Currently, there are multiple
babeldependencies which are unused andbabel/jestis used for test transpilation.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions