FE-7563 - Fix Accessibility Issues with Mentions Plugin#7758
Draft
nineteen88 wants to merge 2 commits intomasterfrom
Draft
FE-7563 - Fix Accessibility Issues with Mentions Plugin#7758nineteen88 wants to merge 2 commits intomasterfrom
nineteen88 wants to merge 2 commits intomasterfrom
Conversation
DipperTheDan
reviewed
Feb 6, 2026
| "version": "7.27.1", | ||
| "dev": true, | ||
| "license": "MIT", | ||
| "peer": true, |
Contributor
There was a problem hiding this comment.
question: are these dependancy changes expected for this piece of work? It looks like you've changed babel/core to a peer dependency here.
Contributor
Author
There was a problem hiding this comment.
Good spot I missed that I'd pushed a package-lock update. That shouldn't be in there I don't believe. I'll get it removed.
edleeks87
reviewed
Feb 6, 2026
|
|
||
| &.selected { | ||
| background: #eee; | ||
| color: #000; |
Contributor
There was a problem hiding this comment.
question (non-blocking): are there any tokens for these colours?
Contributor
There was a problem hiding this comment.
suggestion: I wonder if it'd be better to add the style overrides into the portrait and icon styles instead (at the bottom of the block etc)
// portrait.style
${MentionListItem}.selected & {
color: currentColor;
}
// initials
${StyledPortrait} & {
color: currentColor;
}
// icon.style
${StyledPortrait} & {
color: currentColor;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions