Skip to content

Set "water depth units" col dtype in turbidity CSV#449

Merged
douglatornell merged 1 commit intomainfrom
issue423
Apr 13, 2026
Merged

Set "water depth units" col dtype in turbidity CSV#449
douglatornell merged 1 commit intomainfrom
issue423

Conversation

@douglatornell
Copy link
Copy Markdown
Member

Specified the "water depth units" column as a string type when loading the turbidity CSV. This ensures consistent data handling and prevents potential issues from incorrect type inference due to mixture of m and NaN values in CSV.

re: issue #423

Specified the "water depth units" column as a string type when loading
the turbidity CSV. This ensures consistent data handling and prevents
potential issues from incorrect type inference due to mixture of `m`
and `NaN` values in CSV.

re: issue #423
@douglatornell douglatornell linked an issue Apr 11, 2026 that may be closed by this pull request
@github-actions github-actions bot added this to the v26.1 milestone Apr 11, 2026
@douglatornell douglatornell added bug Something isn't working Workers labels Apr 11, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.71%. Comparing base (c4fb2d7) to head (2d38c60).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
nowcast/workers/make_turbidity_file.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   77.71%   77.71%           
=======================================
  Files         112      112           
  Lines       16525    16525           
  Branches      672      672           
=======================================
  Hits        12843    12843           
  Misses       3616     3616           
  Partials       66       66           
Flag Coverage Δ
unittests 77.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@douglatornell douglatornell merged commit c7d453d into main Apr 13, 2026
9 of 10 checks passed
@douglatornell douglatornell deleted the issue423 branch April 13, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Workers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DtypeWarning in make_turbidity_file

1 participant