Skip to content

Code quality fix - Field names should comply with a naming convention. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisal-hameed wants to merge 1 commit into
base: Minecraft-1.9
Choose a base branch
from
Open

Code quality fix - Field names should comply with a naming convention. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions src/main/java/uk/co/jacekk/bukkit/bloodmoon/command/BloodMoonExecuter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@

public class BloodMoonExecuter extends BaseCommandExecutor<BloodMoon> {

private final String specify_world;
private final String invalid_args_l;
private final String no_perm;
private final String no_perm_start;
private final String no_perm_stop;
private final String not_enabled_world;
private final String specifyWorld;
private final String invalidArgsl;
private final String noPerm;
private final String noPermStart;
private final String noPermStop;
private final String notEnabledWorld;

public BloodMoonExecuter(BloodMoon plugin) {
super(plugin);
this.specify_world = plugin.formatMessage(ChatColor.RED + "You must specify a world when using the command from the console");
this.invalid_args_l = plugin.formatMessage(ChatColor.RED + "Invalid argument length");
this.no_perm = plugin.formatMessage(ChatColor.RED + "You do not have permission use this command");
this.no_perm_start = plugin.formatMessage(ChatColor.RED + "You do not have permission to start a bloodmoon");
this.no_perm_stop = plugin.formatMessage(ChatColor.RED + "You do not have permission to stop a bloodmoon");
this.not_enabled_world = plugin.formatMessage(ChatColor.RED + "The blood moon is not enabled for this world");
this.specifyWorld = plugin.formatMessage(ChatColor.RED + "You must specify a world when using the command from the console");
this.invalidArgsl = plugin.formatMessage(ChatColor.RED + "Invalid argument length");
this.noPerm = plugin.formatMessage(ChatColor.RED + "You do not have permission use this command");
this.noPermStart = plugin.formatMessage(ChatColor.RED + "You do not have permission to start a bloodmoon");
this.noPermStop = plugin.formatMessage(ChatColor.RED + "You do not have permission to stop a bloodmoon");
this.notEnabledWorld = plugin.formatMessage(ChatColor.RED + "The blood moon is not enabled for this world");
}

@CommandHandler(names = {"bloodmoon", "bm"}, description = "Toggles the bloodmoon for the current world.", usage = "[action] [world_name]")
Expand Down Expand Up @@ -78,19 +78,19 @@ public void bloodmoonStart(CommandSender sender, String label, String[] args) {
worldName = args[0];
break;
default:
sender.sendMessage(invalid_args_l);
sender.sendMessage(invalidArgsl);
return;
}
} else {
switch (args.length) {
case 0:
sender.sendMessage(specify_world);
sender.sendMessage(specifyWorld);
return;
case 1:
worldName = args[0];
break;
default:
sender.sendMessage(invalid_args_l);
sender.sendMessage(invalidArgsl);
return;
}
}
Expand All @@ -100,13 +100,13 @@ public void bloodmoonStart(CommandSender sender, String label, String[] args) {
plugin.activate(world);
sender.sendMessage(ChatColor.GREEN + "Bloodmoon started in " + world.getName());
} else {
sender.sendMessage(not_enabled_world);
sender.sendMessage(notEnabledWorld);
}
} else {
sender.sendMessage(ChatColor.RED + "Invalid World");
}
} else {
sender.sendMessage(no_perm_start);
sender.sendMessage(noPermStart);
}
}

Expand All @@ -124,19 +124,19 @@ public void bloodmoonNext(CommandSender sender, String label, String[] args) {
worldName = args[0];
break;
default:
sender.sendMessage(invalid_args_l);
sender.sendMessage(invalidArgsl);
return;
}
} else {
switch (args.length) {
case 0:
sender.sendMessage(specify_world);
sender.sendMessage(specifyWorld);
return;
case 1:
worldName = args[0];
break;
default:
sender.sendMessage(invalid_args_l);
sender.sendMessage(invalidArgsl);
return;
}
}
Expand All @@ -146,13 +146,13 @@ public void bloodmoonNext(CommandSender sender, String label, String[] args) {
plugin.forceNextNight(world);
sender.sendMessage(ChatColor.GREEN + "Bloodmoon forced in " + world.getName());
} else {
sender.sendMessage(not_enabled_world);
sender.sendMessage(notEnabledWorld);
}
} else {
sender.sendMessage(ChatColor.RED + "Invalid World");
}
} else {
sender.sendMessage(no_perm_start);
sender.sendMessage(noPermStart);
}
}

Expand All @@ -170,19 +170,19 @@ public void bloodmoonStop(CommandSender sender, String label, String[] args) {
worldName = args[0];
break;
default:
sender.sendMessage(invalid_args_l);
sender.sendMessage(invalidArgsl);
return;
}
} else {
switch (args.length) {
case 0:
sender.sendMessage(specify_world);
sender.sendMessage(specifyWorld);
return;
case 1:
worldName = args[0];
break;
default:
sender.sendMessage(invalid_args_l);
sender.sendMessage(invalidArgsl);
return;
}
}
Expand All @@ -192,13 +192,13 @@ public void bloodmoonStop(CommandSender sender, String label, String[] args) {
plugin.deactivate(world);
sender.sendMessage(ChatColor.GREEN + "Bloodmoon stopped in " + world.getName());
} else {
sender.sendMessage(not_enabled_world);
sender.sendMessage(notEnabledWorld);
}
} else {
sender.sendMessage(ChatColor.RED + "Invalid World");
}
} else {
sender.sendMessage(no_perm_stop);
sender.sendMessage(noPermStop);
}
}

Expand All @@ -208,7 +208,7 @@ public void bloodmoonReload(CommandSender sender, String label, String[] args) {
plugin.reloadWorldConfig();
sender.sendMessage(ChatColor.GREEN + "Config reloaded for all worlds.");
} else {
sender.sendMessage(no_perm);
sender.sendMessage(noPerm);
}
}

Expand Down