Skip to content

os/board/common: use ftl_nand_initialize when use nand(ext) #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gidori98 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

os/board/common: use ftl_nand_initialize when use nand(ext) #7056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions os/board/common/partitions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ static void configure_partition_name(FAR struct mtd_dev_s *mtd_part, const char
#endif

#ifdef CONFIG_RESOURCE_FS
static int make_resource_mtd_partition(struct mtd_dev_s *mtd, off_t partoffset, off_t nblocks, uint16_t partno)
static int make_resource_mtd_partition(int minor, struct mtd_dev_s *mtd, off_t partoffset, off_t nblocks, uint16_t partno)
{
FAR struct mtd_dev_s *mtd_part;
uint16_t resource_partno;
Expand All @@ -320,11 +320,26 @@ static int make_resource_mtd_partition(struct mtd_dev_s *mtd, off_t partoffset,
return ERROR;
}

#ifdef CONFIG_MTD_NAND
/* TODO If Internal memory is nand, the below code deos not work. So, We need to consider this case ( "type_specific_initialize" should also be reviewed.) */
if (minor > 0) {
/* External flash is NAND */
if (ftl_nand_initialize(resource_partno, mtd_part)) {
printf("ERROR: failed to initialise mtd ftl errno :%d\n", errno);
Copy link
Member

@pcs1265 pcs1265 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just typo, 'initialize', not 'initialise'
(line 333 too)

and line 324 has typo also (deos)

return ERROR;
}
} else {
if (ftl_initialize(resource_partno, mtd_part)) {
printf("ERROR: failed to initialise mtd ftl errno :%d\n", errno);
return ERROR;
}
}
#else
if (ftl_initialize(resource_partno, mtd_part)) {
printf("ERROR: failed to initialise mtd ftl errno :%d\n", errno);
return ERROR;
}

#endif
return OK;
}
#endif
Expand Down Expand Up @@ -423,7 +438,7 @@ int configure_mtd_partitions(struct mtd_dev_s *mtd, int minor, partition_info_t
if (!strncmp(types, "resource,", 9)) {
int nblocks = geo.erasesize / geo.blocksize;
/* Make mtd dev to access resource fs. It starts from offset + erasesize (4K). */
ret = make_resource_mtd_partition(mtd, partoffset + nblocks, partsize / geo.blocksize - nblocks, g_partno);
ret = make_resource_mtd_partition(minor, mtd, partoffset + nblocks, partsize / geo.blocksize - nblocks, g_partno);
if (ret != OK) {
printf("ERROR: fail to make resource mtd part.\n");
}
Expand Down