-
Notifications
You must be signed in to change notification settings - Fork 619
drivers/lcd: Add ioctl to get LCD panel ID #7103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add LCDDEVIO_GETPANELID ioctl command to read 24-bit panel ID. - Implement getpanelid in MIPI LCD driver with lazy init and caching. - Require CMD mode for panel ID read operation. Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
- Add lcd_get_panelid() to retrieve and display the 24-bit LCD panel ID. - Update show_usage() and main() to support the "panelid" command. [USAGE] ``` TASH>>lcd_test panelid TASH>>LCD Panel ID: 0x010000 ``` Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
| }; | ||
|
|
||
| static struct mipi_lcd_dev_s g_lcdcdev; | ||
| static bool g_panelid_initialized = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use private struct variable instead of global.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, we can add it into get_lcdinfo.
| }; | ||
|
|
||
| static struct mipi_lcd_dev_s g_lcdcdev; | ||
| static bool g_panelid_initialized = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, we can add it into get_lcdinfo.
| FAR struct mipi_lcd_dev_s *priv = (FAR struct mipi_lcd_dev_s *)dev; | ||
| int status; | ||
| lcd_mode_t original_mode; | ||
| lcm_setting_table_t read_id_cmd = {0x04, 0, {0x00}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is This command DSC?
If it is specific command, we can wrapping this command to configure or new lcd sepecific api
drivers/lcd
examples
[USAGE]