Bug: Fix race condition, add reduce active worker when closing, add Once prevent double call Close channel#5
Merged
SangTran-127 merged 3 commits intomainfrom Feb 2, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses critical concurrency issues in the WorkerPool implementation by fixing a race condition in ActiveWorkers tracking, preventing double-close panics, and improving error messaging.
Key Changes:
- Fixed race condition by tracking ActiveWorkers with atomic increment/decrement operations instead of bulk assignment
- Added sync.Once protection to prevent panic from calling Stop() multiple times
- Enhanced error message for full task queue to include pool name and capacity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onditions, remove workerpool benchmark file
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.