feat(cards): Add cards component markup and styling#1
Open
SaraevaAnastasia wants to merge 12 commits intomainfrom
Open
feat(cards): Add cards component markup and styling#1SaraevaAnastasia wants to merge 12 commits intomainfrom
SaraevaAnastasia wants to merge 12 commits intomainfrom
Conversation
This commit adds the markup and styling for the cards component. The cards component displays a set of cards, each containing an image, a description, and additional information. The styles are implemented according to the provided design in the test task.
Changes made:
Created HTML markup for the cards component
Applied CSS styles to achieve the desired layout and appearance
Implemented responsive design to ensure compatibility across different devices
SaraevaAnastasia
temporarily deployed
to
github-pages
…e design
This commit adds the markup, styling, and responsive design for the signpost component. The signpost component includes a post with an image, description, and related information. The styles and layout are implemented to ensure compatibility and optimal viewing experience across different devices and screen sizes.
Changes made:
Created HTML markup for the signpost component
Applied CSS styles to achieve the desired layout and appearance
Implemented responsive design techniques, such as media queries and fluid layouts, to adapt the component for various screen sizes
Integrated the signpost component into the existing HTML structure
SaraevaAnastasia
temporarily deployed
to
github-pages
This commit updates the markup and styling for all components to address the provided feedback and requirements. The changes made include: - Replacing non-semantic tags with appropriate semantic tags throughout the codebase - Adjusting font styles, spacing, and element sizes to match the design specifications - Implementing responsive design for all components to ensure they are responsive across different screen sizes - Removing unnecessary absolute positioning and using CSS positioning properties where necessary - Refactoring CSS styles to remove duplicate and unused properties - Ensuring that all components can accommodate varying content heights without overflowing
SaraevaAnastasia
temporarily deployed
to
github-pages
This commit updates the margins for content containers to create spacing between the left and right edges of the page. The previous use of padding has been replaced with margin to achieve the desired layout.
Changes made:
Renamed CSS classes for consistency and clarity
Adjusted margin values to create equal spacing on both sides of the content containers
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
had a problem deploying
to
github-pages
katariniss
reviewed
Jul 5, 2023
css/logo.css
Outdated
| @@ -0,0 +1,15 @@ | |||
| .logo__image { | |||
| display: block; | |||
There was a problem hiding this comment.
Display block was supposed to be added on img tag, you don't need it on svg
css/logo.css
Outdated
| @@ -0,0 +1,15 @@ | |||
| .logo__image { | |||
There was a problem hiding this comment.
If you don't have a "logo" block in the markup, you shouldn't use "logo__element", it contradicts BEM convention
css/nav.css
Outdated
| @@ -0,0 +1,6 @@ | |||
| @media (min-width: 1024px) { | |||
| .nav__item{ | |||
There was a problem hiding this comment.
Same here. If you don't have a "nav" block in the markup, you shouldn't use "nav__item", as it contradicts the BEM convention
css/cardlist.css
Outdated
| @@ -0,0 +1,11 @@ | |||
| .cardlist__card{ | |||
css/description.css
Outdated
| gap: 10px; | ||
| } | ||
| .description__information--first-line{ | ||
| margin-bottom: 11px; |
There was a problem hiding this comment.
better move the margin to the parent element
css/signpost.css
Outdated
| @@ -0,0 +1,14 @@ | |||
| .signpost{ | |||
| margin-top: 80px; | |||
| margin-bottom: 41px; | |||
There was a problem hiding this comment.
better move the bottom margin to the parent element
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
temporarily deployed
to
github-pages
SaraevaAnastasia
temporarily deployed
to
github-pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the markup and styling for the cards component. The cards component displays a set of cards, each containing an image, a description, and additional information. The styles are implemented according to the provided design in the test task.
Changes made: