Miryam/google drive #177
Open
Miryam/google drive #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiryamGabay
requested review from
EA171,
SariGlick and
e171271
as code owners
Collaborator
Shoshana-Yudelevitz
left a comment
Shoshana-Yudelevitz
left a comment
There was a problem hiding this comment.
גוגל דריב -מרים
EA171
requested changes
Sep 5, 2024
| onSuccess: async (tokenResponse) => { | ||
| const accessToken = tokenResponse.access_token; | ||
|
|
||
| //כרגע מעלה לדריב קובץ חסר משמהות |
Collaborator
There was a problem hiding this comment.
change it to got the file from props
Collaborator
There was a problem hiding this comment.
the file should come from props
| }, | ||
| } | ||
| ); | ||
| console.log('File uploaded:', response.data); |
EA171
requested changes
Sep 8, 2024
| import { store } from './redux/store.jsx'; | ||
| import { SnackbarProvider } from 'notistack'; | ||
| import './App.scss'; | ||
| import { GoogleOAuthProvider } from '@react-oauth/google'; |
| }, | ||
| (error) => { | ||
| if (error.response.status === 401) { | ||
| window.location.href = '/login'; |
Collaborator
There was a problem hiding this comment.
what means this window.location?
| const ManagerGoogleDrive = () => { | ||
| const fileContent = "Hello, world!"; | ||
| const fileName = 'yourfile.txt'; | ||
| const fileMimeType = 'text/plain'; |
Collaborator
There was a problem hiding this comment.
what is this hard-coded values?
| }, | ||
| { | ||
| path: '/reports', | ||
| element: <ManagerGoogleDrive/> |
Collaborator
There was a problem hiding this comment.
this is not the reports UI, this should be only a button inside the reports page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
הקובף שעולה לדריב זה קובץ TXT שיצרתי בתוך הקומפוננטה!
תגידי לי איך את רוצה שאני יקבל את הקובץ ואני ישנה את זה!
(האם לקבל רק נתונים כ-props וליצור אותם בתוך קובץ או אולי לקבל קובץ....)