-
Notifications
You must be signed in to change notification settings - Fork 131
verification of container content page synced tab #20312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
verification of container content page synced tab #20312
Conversation
7c09deb to
d3d5331
Compare
|
|
PRT Result |
|
|
PRT Result |
ianballou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good to me! I like that you also sync flatpak repositories. One note - you technically don't need to set up the flatpak remotes, you could just sync the flatpak repository directly. It does tie this test's success to the flatpak remote feature's success, which is a bit different.
d3d5331 to
cb0ada8
Compare
|
|
PRT Result |
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def synced_container_and_flatpak_repos(module_org, module_product, module_target_sat): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this fixture? It's not used in your test case (removed in the second commit) and IMHO it shouldn't be needed for container image UI testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can remove this, This function had been written as per the testing steps mentioned in the upstream katello-11538 PR
Problem Statement
6.19.0 Feature Story https://issues.redhat.com/browse/SAT-38202
Verify expandable table for Synced image tags in the Synced images tab.
Solution
Added airgun support along with newly written test case
SatelliteQE/airgun#2215
Related Issues
PRT test Cases example