Merge 3rd stream #8
Conversation
| const requestHash = hashArguments(sender_id, recipient_id, amount); | ||
|
|
||
| const redisCheckResult = await checkRedisHash(sender_id, requestHash); | ||
|
|
||
| if (!redisCheckResult.success) { | ||
| return { | ||
| success: false, | ||
| error: 'Duplicate transaction', | ||
| }; | ||
| } |
There was a problem hiding this comment.
@uncoooloj this is where I used the implementation for #3.
There was a problem hiding this comment.
Seen it, what if transactions are just a few milli seconds apart?
That's my fear. The system won't be done with this IO so both will pass.
What do you think?
There was a problem hiding this comment.
Yeah, @uncoooloj Redis also has implementations for transactions and optimistic locking.
I'll update it in the final version.
There was a problem hiding this comment.
so quick question, what if there was a request throttling to one request per 10 ms for example? sounds like a lazy hack but that + a transaction has solves our problem no?
| const addElement = promisify(client.sadd).bind(client); | ||
| const expireElement = promisify(client.expire).bind(client); | ||
|
|
||
| async function checkRedisHash(accountId, hash) { |
There was a problem hiding this comment.
@uncoooloj this is the implementation for #3.
No description provided.