Simplify mixed precision: compute types on demand instead of caching #759
+81
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Modified all 6 mixed precision implementations to compute
T32
andTorig
types on demand insolve!
functions instead of storing them in the cache:MKL32MixedLUFactorization
OpenBLAS32MixedLUFactorization
AppleAccelerate32MixedLUFactorization
RF32MixedLUFactorization
CUDAOffload32MixedLUFactorization
MetalOffload32MixedLUFactorization
Before
After
Performance
The type computations (
eltype(A) <: Complex
andeltype(cache.u)
) are simple operations that don't allocate, so computing them on demand has negligible performance impact while making the code cleaner and easier to understand.Related
This is a cleaner reimplementation of #758 based on review feedback.
🤖 Generated with Claude Code