Fix OptimizationMOI maxiters warning by implementing solver-specific parameter mapping #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
maxiters
interfaceChanges Made
Added
_set_maxiters!
function that automatically mapsmaxiters
to solver-specific parameters:max_iter
IterationLimit
CPX_PARAM_ITLIM
limits/iterations
MSK_IPAR_INTPNT_MAX_ITERATIONS
max_iter
maxit
max_iters
max_iter
Generic fallback that tries common parameter names for unknown solvers
Comprehensive error handling with informative warnings when mapping fails
Added tests to verify the functionality works correctly
Problem Solved
Before this PR, using
solve(prob, optimizer; maxiters=100)
would show the warning:After this PR, the
maxiters
parameter is automatically mapped to the correct solver-specific parameter without warnings for supported solvers.Test Plan
_set_maxiters!
function handles known solvers correctlysolve()
functionCloses
Fixes #844
🤖 Generated with Claude Code