Add command-line options to launch emulator with specified ROM and datapack file paths#3
Open
James-Livesey wants to merge 5 commits intoScottRichardsCG:masterfrom
Open
Add command-line options to launch emulator with specified ROM and datapack file paths#3James-Livesey wants to merge 5 commits intoScottRichardsCG:masterfrom
James-Livesey wants to merge 5 commits intoScottRichardsCG:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Just thought I'd contribute a few command-line options that can be used to start the emulator with a ROM pre-loaded, without needing to open the right ROM file from the file picker. I've also implemented command-line options to pre-load datapacks, too. More info on the options is available by running
psiorawith the--helpflag.I needed to implement this in order to use your emulator as part of my efforts to write my own datapacks in 6303 assembly — being able to quickly launch the emulator with the latest assembled datapack already enabled makes debugging my own code much easier. Thought I'd share my changes upstream so that others can benefit from this feature.
I also fixed an issue where SDL2 was not able to write characters to the screen as part of LCD emulation, I believe due to conflicts with Qt 5 which is using OpenGL (SDL2 was unable to grab the rendering context when needed). I'm not sure if this bug is just a Linux thing (what I'm using). I've implemented a minor fix in the .ui file to use a
QOpenGLWidget, which fixed the issue. I then also proceeded to nest the progress bar in aQStatusBarin order to ensure that the UI looks okay. You may need to try out these changes on your end to ensure that they work as intended for you.Many thanks,
-James.