vc_render_tifxyz: provide voxel size scale to ome-zarr#804
vc_render_tifxyz: provide voxel size scale to ome-zarr#804
Conversation
jrudolph
requested review from
SuperOptimizer and
hendrikschilling
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afaebb666f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| double s = std::pow(2.0, l); | ||
| const double sz = 1.0; | ||
| const double sYX = baseVoxelSize * std::pow(2.0, l); | ||
| const double sZ = baseVoxelSize; |
There was a problem hiding this comment.
writeZarrAttrs now writes physical OME-Zarr scales, but it hardcodes sZ to baseVoxelSize and ignores the actual rendered slice spacing. When vc_render_tifxyz is run with --slice-step > 1, consecutive output slices are farther apart than one source voxel, so this metadata underreports Z spacing and yields incorrect physical distances/aspect ratios in downstream consumers. Because sliceStep is already passed into writeZarrAttrs, the Z scale should incorporate it (while remaining constant across pyramid levels if Z is preserved).
Useful? React with 👍 / 👎.
2 participants
Supersedes #737