resolve #8 add CloseMarkdownDrawer #9
Conversation
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request adds a function to close the markdown drawer and a corresponding command. The functionality seems straightforward and useful. However, there's a minor naming inconsistency that should be addressed.
Summary of Findings
- Command Naming Consistency: The command
MarkDrawerCloseinftplugin/markdown.vimcalls a function namedCloseMarkdownClose, which seems inconsistent. It should callCloseMarkdownDrawerfor clarity and consistency.
Assessment
The pull request introduces a new command to close the Markdown drawer, which enhances the user experience. The changes are relatively small, but I've identified a potential issue with the command name in ftplugin/markdown.vim. I recommend addressing this comment before merging. Please have others review and approve this code before merging.
| endif | ||
|
|
||
| command! MarkDrawer :call ui#OpenMarkdownDrawer() | ||
| command! MarkDrawerClose :call ui#CloseMarkdownClose() |
There was a problem hiding this comment.
The command MarkDrawerClose calls CloseMarkdownClose, but the function in ui.vim is named CloseMarkdownDrawer. For consistency, should this call ui#CloseMarkdownDrawer() instead?
command! MarkDrawerClose :call ui#CloseMarkdownDrawer()
No description provided.