Skip to content

Fix multi-model dispatcher indexing and column order#3

Closed
michaelzehetleitner wants to merge 1 commit intoSeHellmann:mainfrom
michaelzehetleitner:pr2-multimodel-dispatch
Closed

Fix multi-model dispatcher indexing and column order#3
michaelzehetleitner wants to merge 1 commit intoSeHellmann:mainfrom
michaelzehetleitner:pr2-multimodel-dispatch

Conversation

@michaelzehetleitner
Copy link
Copy Markdown

Summary

  • normalize optional scalar columns (e.g., st0, sz, sv, wx, wrt, wint) in
    every predictor and simulator before they are used or passed to C++
  • rebuild theta*/thetaUpper*/thetaLower* columns defensively so sparse
    parameter sets (including nRatings == 1) no longer trigger undefined-column
    errors
  • remove the previous NA-based column dropping so that callers can omit
    optional parameters without breaking downstream models

Testing

  • pkgload::load_all(".")
  • testthat::test_dir("tests/testthat")

@SeHellmann
Copy link
Copy Markdown
Owner

Does not really change behavior, but I am sure, the current version works as intended. So, not merged.

@SeHellmann SeHellmann closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants