Open
Conversation
We need 9.8.0 release, since DIH-9.7.0 doesn't work on Solr 9.8.0 ;-( Please
Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com> Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/a7780a43-079d-4a2a-a53c-71a4bfe33456
…ient/Guava removals Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com> Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/a7780a43-079d-4a2a-a53c-71a4bfe33456
…uild setup - Updated pom.xml to upgrade Java version from 11 to 17 with corresponding compiler settings - Modified .gitignore to include comprehensive ignore patterns for dependencies, logs, temp files, and editor configurations - Enhanced Maven compiler plugin configuration to support Java 17 source and target compatibility - Improved project properties with updated Java version and release settings for better build consistency The changes modernize the project's Java version requirements while providing better build environment management through improved git ignore rules and compiler configurations.
…uild setup - Updated pom.xml to upgrade Java version from 11 to 17 with corresponding compiler settings - Modified .gitignore to include comprehensive ignore patterns for dependencies, logs, temp files, and editor configurations - Enhanced Maven compiler plugin configuration to support Java 17 source and target compatibility - Improved project properties with updated Java version and release settings for better build consistency The changes modernize the project's Java version requirements while providing better build environment management through improved git ignore rules and compiler configurations.
Update from task d5a4b665-3973-4ada-88fd-1a6092b4a55d
Key features implemented: - Updated DataImportHandler.java to replace deprecated MetricsMap with SolrMetricManager.MetricGauge and updated OpenTelemetry attributes initialization - Modified HTMLStripTransformer.java to use HTMLStripCharFilterFactory instead of direct HTMLStripCharFilter instantiation - Updated SolrEntityProcessor.java to replace SolrQuery with QueryRequest and XMLResponseParser with appropriate response parsers for SolrJ client compatibility - Refined .gitignore to include comprehensive file patterns for ignored files and compressed archives These changes address compilation errors caused by API changes in Solr 10 while maintaining backward compatibility and improving test coverage for the data import handler functionality.
Update from task 50ce9eda-d862-494e-bb45-9b42e28465e3
Key features implemented: - Updated .gitignore to standardize ignored files and directories - Refactored DIHCacheSupport.java to replace deprecated SolrException.log usage - Modified DataImporter.java to remove deprecated SolrException.log calls - Updated DocBuilder.java to eliminate deprecated SolrException.log invocations - Adjusted EntityProcessorBase.java to replace deprecated exception logging - Modified EntityProcessorWrapper.java to remove deprecated logging calls - Updated HTMLStripTransformer.java to use correct import path for HTMLStripCharFilterFactory - Modified SolrEntityProcessor.java to remove deprecated SolrQuery import and related usages - Updated SolrWriter.java to remove deprecated SolrException.log usage These changes address compilation errors caused by deprecated methods and updated import paths required for Solr 10 compatibility, while maintaining existing functionality. The updates primarily focus on replacing deprecated SolrException.log methods with direct logger calls and updating import statements to match Solr 10's API changes.
…handler-a4090 Update from task 978c5ed2-ea36-45de-92c2-fbf653ca4090
…y instead of factory Key features implemented: - Remove import of org.apache.solr.analysis.HTMLStripCharFilterFactory from HTMLStripTransformer.java - Replace factory pattern usage with direct instantiation of org.apache.lucene.analysis.charfilter.HTMLStripCharFilter - Update transformer logic to wrap readers directly with new HTMLStripCharFilter(reader) - Maintain same HTML stripping functionality while simplifying the implementation - Update class documentation to reference HTMLStripCharFilter instead of factory class The change simplifies the HTML stripping implementation by removing unnecessary factory wrapper and directly using the character filter, making the code more straightforward while preserving the same functionality.
…8d53 Update from task a7cd1fe6-140c-4bf8-8da4-6ae4055f8d53
-Key features implemented: -Updated import statement in SolrEntityProcessor.java from org.apache.solr.client.solrj.SolrQuery to org.apache.solr.client.solrj.request.SolrQuery -Updated import statement in TestSolrEntityProcessorUnit.java from org.apache.solr.client.solrj.SolrQuery to org.apache.solr.client.solrj.request.SolrQuery -Reverted .gitignore file to original content and added protection against future changes -The import path update ensures correct usage of SolrQuery class from the request package -Test coverage maintained with updated import statements matching the new package location
…x-8c0ea Update from task f5406b80-2ead-43b6-bb80-f7452d38c0ea
Key features implemented: - Added lucene-analysis-common dependency to resolve HTMLStripCharFilter import issue - Removed deprecated SolrMetricManager.MetricGauge usage and updated initializeMetrics override for Solr 10 metrics API compatibility - Removed JsonResponseParser and XMLResponseParser imports and simplified HttpJdkSolrClient initialization in SolrEntityProcessor - Replaced removed CoreDescriptor.isConfigSetTrusted() call with no-op in EntityProcessorWrapper - Updated SolrCloudWriter to remove deprecated DocCollection.getActiveSlicesArr() and UpdateRequest.setBasePath() usage - Changed SimplePropertiesWriter to use core.getInstanceDir() instead of removed getResourceLoader().getConfigDir() - Modified ZKPropertiesWriter to use simplified SolrZkClient.getData() signature compatible with Solr 10 These changes provide forward compatibility with Solr 10.0.0 by addressing all breaking API changes while maintaining core functionality. The updates focus on removing deprecated metric APIs, updating ZooKeeper client signatures, and adjusting core resource loading patterns.
…s-4d7d4 Update from task ca3dbba4-b465-46db-8232-9c99f234d7d4
…Request - Replace DirectXmlRequest with ContentStreamUpdateRequest in TestContentStreamDataSource.java to maintain JDK 21 compatibility - Update imports to use ContentStreamUpdateRequest and ContentStreamBase.StringStream for XML request handling - Modify testSimple() and testCommitWithin() methods to use new content stream approach with proper XML payload transmission - Maintain existing test functionality while ensuring compilation success under Java JDK 21 This change resolves the compilation failure caused by the removal of DirectXmlRequest while preserving the original test behavior through the new content streaming API.
…df12 Update from task 66985c95-eb58-4302-821b-b009c801df12
Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/5b20845a-67d8-48a6-9dec-e9a9b836490b Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
…solr-10 Fix test compilation failures for Solr 10 API migration
…rtiesWriter, CVE bumps Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/15d2eb9d-ff4a-4e85-987b-6f24942b4328 Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
…porthandler Fix TestDataConfig failure: ExternalPaths init + retarget PR onto copilot/upgrade-to-solr-10
…intage-engine Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/6b1345b5-ca90-4c32-8f7c-fcf0eeb335c7 Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
[WIP] Fix error on JDK 21 for test execution
… fix Derby 10.15.x split jars Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/5cf4a1b8-c847-4a55-bf1e-b90f57abcc7f Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
[WIP] Fix test error requiring JDK 21
…lve null serverBaseUrl NPE Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/a19f4e11-559c-4434-9d6e-a009ab592cc4 Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
…date Agent-Logs-Url: https://github.com/mkhludnev/dataimporthandler/sessions/a19f4e11-559c-4434-9d6e-a009ab592cc4 Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
…-url Fix null serverBaseUrl NPE in SolrCloudWriter commit/delete operations
Contributor
Author
|
snapshot build is mkhludnev#5 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.