[CLONE/FIXES][FEATURE]: Generics, lifetimes, where clauses and internal field variant formatting #6
+398
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump version number before publish - `gen` is a reserved keyword: https://doc.rust-lang.org/edition-guide/rust-2024/gen-keyword.html - Rename all functions named `gen` to `generate` - Allow for local testing via workspaces, however when publishing the local dep needs to be replaced with the published version - This allowed for the actual proc_macro code changes to propegate into the local build.
…the published version
SeedyROM
changed the title
SeedyROM
commented
Jul 15, 2025
| @@ -67,9 +94,26 @@ mod tests { | |||
| DateOfBirth(u32, u32, u32), | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
| #[derive(EnumDisplay)] | |||
| enum TestEnumWithGenerics<'a, T: Clone> | |||
There was a problem hiding this comment.
Should this struct be called TestEnumWithLifetimeAndGenerics? Enforcing that each generic have a lifetime doesn't make much sense.
There was a problem hiding this comment.
We should probably have tests for both. One where the test struct has T's without references, or boxed Ts.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Branched from #5, see that PR for full details.
Fixes
genas it's a reserved keywordcargo clippyandcargo fmt