Skip to content

Add ASAGI find via CMake config#76

Merged
vikaskurapati merged 1 commit intomasterfrom
davschneller/asagi-config
Apr 24, 2025
Merged

Add ASAGI find via CMake config#76
vikaskurapati merged 1 commit intomasterfrom
davschneller/asagi-config

Conversation

@davschneller
Copy link
Copy Markdown
Contributor

For the change due to TUM-I5/ASAGI#17 .

@davschneller davschneller marked this pull request as ready for review April 22, 2025 10:27
@vikaskurapati vikaskurapati merged commit 4f87b84 into master Apr 24, 2025
2 checks passed
@vikaskurapati vikaskurapati deleted the davschneller/asagi-config branch April 24, 2025 14:27
@Thomas-Ulrich
Copy link
Copy Markdown
Contributor

might have been better to wait for
TUM-I5/ASAGI#17
(but I guess it is ready)

@davschneller
Copy link
Copy Markdown
Contributor Author

Actually, this PR should make it work with "old" and "new" ASAGI. I.e. if ASAGI isn't found via CMake config, it'll resort to PkgConfig instead.
(actually, that's also a small TODO for SeisSol still)

@Thomas-Ulrich
Copy link
Copy Markdown
Contributor

would it facilitate creating a pip module for easi bindings?
(then we can remove the default easi bindings to the spack package if you want ;-))

@davschneller
Copy link
Copy Markdown
Contributor Author

Hmm; maybe—I don't know to be honest. :) Maybe I'm still out of the loop—what was the issue for that before?

@Thomas-Ulrich
Copy link
Copy Markdown
Contributor

Thomas-Ulrich commented Apr 24, 2025

I guess it is quite involved because it depends on MPI, hdf5 and asagi.
we can also continue relying on spack, or on docker.

@davschneller
Copy link
Copy Markdown
Contributor Author

Ok, I think I see what you mean. Then probably and sadly, the answer will still be: no, the situation hasn't really improved.
Though maybe it might be possible to just add a setup.py here—in the end, something like gmsh is also distributed via pip in binary form. (and it might be possible to split the Python package from the easi main a bit more even—by just making it a shallow adapter in some subfolder or extra repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants