add custom attribute adding function#13
Open
Lishen1 wants to merge 2 commits intoSelamaAshalanore:mainfrom
Open
add custom attribute adding function#13Lishen1 wants to merge 2 commits intoSelamaAshalanore:mainfrom
Lishen1 wants to merge 2 commits intoSelamaAshalanore:mainfrom
Conversation
Owner
|
This approach is promising. I'll look at the test cases. You are welcome to adjust the tests, too, if you willing to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to solve some problems:
1 - no ability to add custom attribute (no api in current implementation)
2 - strings quoting not always good (no way no embed html into tabel for example)