-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Use in-house tools image to avoid pulling rate-limits #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 509e2df)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
ca0ba2a
to
9b07392
Compare
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
9b07392
to
6bbe1a5
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add custom tools Docker image with kubectl
Replace external kubectl image with in-house version
Update Makefile build targets and tagging
Increase autoscaling job timeout to 600 seconds
Diagram Walkthrough
File Walkthrough
Dockerfile
Create custom tools image with kubectl
.tools/Dockerfile
Makefile
Integrate tools image into build system
Makefile
CONFIGURATION.md
Update documentation for new tools image
charts/selenium-grid/CONFIGURATION.md
values.yaml
Switch to in-house tools image configuration
charts/selenium-grid/values.yaml