Skip to content

Conversation

Benjamin-Loison
Copy link

@Benjamin-Loison Benjamin-Loison commented Sep 28, 2025

User description

grep -rw doesnot
Output:
website_and_docs/content/documentation/grid/configuration/cli_options.zh-cn.md:| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network doesnot allow websockets. True by default. |
website_and_docs/content/documentation/grid/configuration/cli_options.pt-br.md:| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network doesnot allow websockets. True by default. |
website_and_docs/content/documentation/grid/configuration/cli_options.en.md:| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network doesnot allow websockets. True by default. |
find -type f | xargs sed -i 's/doesnot/does not/g'

solves the issue.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Fix typo "doesnot" to "does not" in documentation

  • Update CLI options documentation across multiple languages


File Walkthrough

Relevant files
Documentation
cli_options.en.md
Fix typo in English CLI options                                                   

website_and_docs/content/documentation/grid/configuration/cli_options.en.md

  • Fixed typo "doesnot" to "does not" in --enable-cdp option description
+1/-1     
cli_options.pt-br.md
Fix typo in Portuguese CLI options                                             

website_and_docs/content/documentation/grid/configuration/cli_options.pt-br.md

  • Fixed typo "doesnot" to "does not" in --enable-cdp option description
+1/-1     
cli_options.zh-cn.md
Fix typo in Chinese CLI options                                                   

website_and_docs/content/documentation/grid/configuration/cli_options.zh-cn.md

  • Fixed typo "doesnot" to "does not" in --enable-cdp option description
+1/-1     

```
grep -rw doesnot
```
<details>
<summary>Output:</summary>

```
website_and_docs/content/documentation/grid/configuration/cli_options.zh-cn.md:| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network doesnot allow websockets. True by default. |
website_and_docs/content/documentation/grid/configuration/cli_options.pt-br.md:| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network doesnot allow websockets. True by default. |
website_and_docs/content/documentation/grid/configuration/cli_options.en.md:| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network doesnot allow websockets. True by default. |
```
</details>

```bash
find -type f | xargs sed -i 's/doesnot/does not/g'
```

solves the issue.
Copy link

netlify bot commented Sep 28, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 52f20b8

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Consistency

Ensure the phrasing and capitalization for the --enable-cdp description matches style elsewhere (e.g., “WebSockets” vs “websockets”, and punctuation spacing before “True by default.”).

| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network does not allow websockets. True by default. |
| `--enable-managed-downloads`| boolean | `false` | This causes the Node to auto manage files downloaded for a given session on the Node. |
Localization

The updated sentence remains in English within a pt-br page; consider translating or aligning with the page’s language conventions.

| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network does not allow websockets. True by default. |
| `--enable-managed-downloads`| boolean | `false` | This causes the Node to auto manage files downloaded for a given session on the Node. |
Localization

The updated sentence remains in English within a zh-cn page; consider translating or aligning with the page’s language conventions.

| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network does not allow websockets. True by default. |
| `--enable-managed-downloads`| boolean | `false` | This causes the Node to auto manage files downloaded for a given session on the Node. |

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Translate documentation to Portuguese

Translate the English description for the --enable-cdp option to Portuguese in
the cli_options.pt-br.md file.

website_and_docs/content/documentation/grid/configuration/cli_options.pt-br.md [231]

-| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network does not allow websockets. True by default. |
+| `--enable-cdp`| boolean | `true` | Habilita o proxy CDP na Grid. Um administrador da Grid pode desabilitar o CDP se a rede não permitir websockets. Verdadeiro por padrão. |
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that a line in a Portuguese documentation file is in English and proposes a translation, which improves the quality and consistency of the localization.

Low
Translate documentation to Chinese

Translate the English description for the --enable-cdp option to Chinese in the
cli_options.zh-cn.md file.

website_and_docs/content/documentation/grid/configuration/cli_options.zh-cn.md [238]

-| `--enable-cdp`| boolean | `true` | Enable CDP proxying in Grid. A Grid admin can disable CDP if the network does not allow websockets. True by default. |
+| `--enable-cdp`| boolean | `true` | 在 Grid 中启用 CDP 代理。如果网络不允许 WebSocket,Grid 管理员可以禁用 CDP。默认为真。 |
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that a line in a Chinese documentation file is in English and proposes a translation, which improves the quality and consistency of the localization.

Low
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants